-
-
Notifications
You must be signed in to change notification settings - Fork 335
Add testing for websocket server (WIP: Do not merge) #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum set at 15 seconds, each retry adds 30 seconds.
invoke callbacks of destroyed trackers
Scrape implementation for websocket. Issue webtorrent#116
Don't add non-secure trackers on a https site
Reconnect timeout improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add the websocket tracker to the test suite.
It is based on my scrape implementation (PR #125) because it is one required in the existing test case and the addition of the wrtc package (sorry about that).
I improved the closing of the websocket tracker in the client to prevent hanging at the end of the case but there are still 2 sockets running and I cannot get rid of it.
I believe the remaining socket are between the peers (because it does not happens for one peer) but I can achieve to find it.
I use the command
wtfnode test/server.jsto show the opened resources after the end of the test and I shows:I leave this PR to get some help from you.
Any though?