Skip to content

Conversation

@yciabaud
Copy link
Contributor

This PR attempts to add the websocket tracker to the test suite.
It is based on my scrape implementation (PR #125) because it is one required in the existing test case and the addition of the wrtc package (sorry about that).

I improved the closing of the websocket tracker in the client to prevent hanging at the end of the case but there are still 2 sockets running and I cannot get rid of it.

I believe the remaining socket are between the peers (because it does not happens for one peer) but I can achieve to find it.

I use the command wtfnode test/server.js to show the opened resources after the end of the test and I shows:

ok 100 should be equal
^C[WTF Node?] open handles:
- Sockets:
  - undefined:undefined -> undefined:undefined
    - Listeners:
  - undefined:undefined -> undefined:undefined
    - Listeners:

1..100
# tests 100
# pass  100

# ok

I leave this PR to get some help from you.
Any though?

DiegoRBaquero and others added 30 commits March 11, 2016 04:12
Minimum set at 15 seconds, each retry adds 30 seconds.
Scrape implementation for websocket. Issue webtorrent#116
Don't add non-secure trackers on a https site
@yciabaud yciabaud closed this Mar 16, 2016
@yciabaud yciabaud deleted the ws-test branch March 16, 2016 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants