Don't add non-secure trackers on a https site #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new UDPTracker(self, announceUrl) | ||
| } else if ((protocol === 'ws:' || protocol === 'wss:') && webrtcSupport) { | ||
| // Don't try to add http tracker on an https website | ||
| if (protocol === 'ws:' && location && location.protocol && location.protocol === 'https:') { |
Member
There was a problem hiding this comment.
This will crash in Node.js (for example, in webtorrent-hybrid) because location is not defined.
feross
added a commit
that referenced
this pull request
Mar 16, 2016
Don't add non-secure trackers on a https site
Member
|
I will fix this up post-merge. |
Member
|
7.5.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webtorrent/webtorrent#67