invoke callbacks of destroyed trackers#126
Merged
feross merged 1 commit intowebtorrent:masterfrom Mar 15, 2016
autarc:fix-callback-on-destroy
Merged
invoke callbacks of destroyed trackers#126feross merged 1 commit intowebtorrent:masterfrom autarc:fix-callback-on-destroy
feross merged 1 commit intowebtorrent:masterfrom
autarc:fix-callback-on-destroy
Conversation
Contributor
|
+1 |
| HTTPTracker.prototype.destroy = function (cb) { | ||
| var self = this | ||
| if (self.destroyed) return | ||
| if (self.destroyed) return cb && cb() |
Member
There was a problem hiding this comment.
No need for cb &&. You can see that we just call cb() directly below. This is an internal function, so we're always sure that it's called with a cb parameter.
Member
There was a problem hiding this comment.
Also, should be cb(null) for consistency with how it's called below.
feross
added a commit
that referenced
this pull request
Mar 15, 2016
invoke callbacks of destroyed trackers
Member
|
Thanks for catching this issue and sending an excellent PR! I made a few changes here: 6df64ff |
Member
|
Released as 7.4.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the client waits for the callback signal of all trackers - including the ones which were previously unable to connect and destroyed. Since the process stays open, the torrents which reference them as their discovery won't be destroyed either and in the end prevent closing the webtorrent client.