Scrape implementation for websocket. Issue #116 #125
Merged
+101
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var self = this | ||
| // NOTE: the unofficial spec says to use the 'files' key, 'host' has been | ||
| // seen in practice | ||
| data = data.files || data.host || {} |
Member
There was a problem hiding this comment.
We should just use files since this is the first implementation. We don't need to support hacks for bad tracker servers.
feross
added a commit
that referenced
this pull request
Mar 16, 2016
Scrape implementation for websocket. Issue #116
Member
|
I will make the changes that I suggested in inline comments and do a release. |
Member
|
Released as 7.5.0. |
| } else if (data.action === common.ACTIONS.SCRAPE) { | ||
| self._onScrapeResponse(data) | ||
| } else { | ||
| throw new Error('invalid action in WS response: ' + data.action) |
Member
There was a problem hiding this comment.
Just noticed this: Throwing is a bad idea. That means that any tracker that sends back an invalid response will cause an uncaught exception in the client. This should just call self._onSocketError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the scrape function available on websocket server. I chose to add a property named action in the payload to filter requests on server side.
There are a lot of diffs but it is mainly copies from http server and refactoring.
PS: I was able to test it with the WS suite I am willing to integrate (but that's another PR ;) )