Add testing for websocket server #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| socket: undefined | ||
| }) | ||
| } else { | ||
| t.equal(swarm.peers[peerId.toString('hex')].complete, false) |
Member
There was a problem hiding this comment.
Why not test the rest of the properties on the swarm?
Member
|
Nice work! It's great to have some tests for the websocket server! And especially nice work finding that we were closing the pooled socket even though others might be using it. |
Member
|
I'll merge and fix up your PR myself, because I want to release the pooled socket fix quickly. |
Member
|
Merged, though GitHub is not showing it for some reason. |
Member
|
@yciabaud I made all the changes – let me know if I misunderstood something and we can change it back. |
Contributor
Author
|
No problem with your fixes, thank you for merging. I am glad we have some tests on WS server too, this should avoid some bugs in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the websocket tracker to the test suite.
It is based on my scrape implementation (PR #125) because it is one required in the existing test case and the addition of the electron-webrtc package.
I improved the closing of the websocket tracker in the client to prevent hanging at the end of the case.