feat: TT-578 improve the style of the form element #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 95.64% 97.40% +1.75%
==========================================
Files 107 107
Lines 2273 2427 +154
Branches 175 203 +28
==========================================
+ Hits 2174 2364 +190
+ Misses 54 23 -31
+ Partials 45 40 -5
Continue to review full report at Codecov.
|
LuisMS7
suggested changes
Mar 14, 2022
Comment on lines
123
to
126
| .url-ticket-input { | ||
| border: 1px solid #ced4da !important; | ||
| border-radius: 0.25rem !important; | ||
| } |
There was a problem hiding this comment.
It would be better if the selector is .form-control.url-ticket-input to avoid the use of "!important".
There was a problem hiding this comment.
Actually it's not necessary the !important tag, I'll remove it.
| border: 1px solid #ced4da; | ||
| border-radius: 0.25rem; | ||
| padding: 2px; | ||
| } |
There was a problem hiding this comment.
Consider adding a new line at the end of the file.
|
Kudos, SonarCloud Quality Gate passed!
|
LuisMS7
approved these changes
Mar 14, 2022
jatobrun
added a commit
that referenced
this pull request
Mar 22, 2022
* feat: TT-509 Use terraform to provision ui infraestructure * feat: TT-580 Missing placeholders (#820) * feat: TT-580 Missing placeholders * feat: TT-580 add placeholders in ticket uri and description text inputs on the time clock page Co-authored-by: Luis Moyon <[email protected]> * chore(release): 1.66.0 [skip ci]nn * TT-xx: Fix make publish tasks (#822) * fix: TT-509 expose port 8080 in docker images * fix: TT-509 change app to port 80 * feat: TT-578 improve the style of the form element (#823) * feat: TT-578 improve the style of the form element * chore(release): 1.67.0 [skip ci]nn * TT-582 Improve the summary section of the time-clock page and the clock out button (#824) * style: TT-582 improve the summary section with a new row with information of actual clock in register and clock out button * fix: TT-582 add missing unit test to confirm that clockout function in TimeEntriesSummaryComponent emits an event * style: TT-582 add a border radius to current elapsed time box Co-authored-by: David Cadena <[email protected]> * fix: TT-509 including empty line in all files * fix: TT-509 Change the dockerfile to use root user and not app user * feat: TT-576 Improve grids visual presentation and function (#826) * feat: TT-576 Improve grids visual presentation and function * chore(release): 1.68.0 [skip ci]nn * feat: TT-577 get profile pic from Google account (#825) * feat: TT-577 get profile pic from Google account * feat: TT-577 get profile pic from Google account * feat: TT-577 get profile pic from Google account Co-authored-by: alejandra-ponce <[email protected]> * chore(release): 1.69.0 [skip ci]nn * Revert "feat: TT-577 get profile pic from Google account (#825)" (#829) This reverts commit 3bee7e3. Co-authored-by: Carlos Carvajal <[email protected]> * chore(release): 1.69.1 [skip ci]nn * style: TT-579 Buttons and searchbar adjusted to the app style (#827) * fix: TT-590 unable to pass ci test (#831) * chore(release): 1.69.2 [skip ci]nn * Tt 582 improve the summary section of the time clock page QA (#830) * style: TT-582 improve the summary section with a new row with information of actual clock in register and clock out button * fix: TT-582 add missing unit test to confirm that clockout function in TimeEntriesSummaryComponent emits an event * style: TT-582 add a border radius to current elapsed time box * style: TT-582 improved the clocked in hour text and current time box * style: TT-582 improved the clocked in hour text and current time box * style: TT-582 removed whitespace Co-authored-by: Luis Moyón <[email protected]> * fix: TT-509 pr comments * fix: TT-509 using remote state to load variables * Update variables.tf * delete prefix docker * delete prefix docker in locals block * fix: Update the values of the terraform state output Co-authored-by: alejandra-ponce <[email protected]> Co-authored-by: Luis Moyon <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Fausto Castaneda <[email protected]> Co-authored-by: iHackN3WTON <[email protected]> Co-authored-by: LuisMS7 <[email protected]> Co-authored-by: David Cadena <[email protected]> Co-authored-by: Kevin Joseph Duy Hurtado <[email protected]> Co-authored-by: alejandra-ponce <[email protected]> Co-authored-by: Carlos Carvajal <[email protected]> Co-authored-by: MarcoAguirre <[email protected]> Co-authored-by: FreddyJR1995 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.