feat: TT-509 Use terraform to provision ui infraestructure #819

jatobrun · 2022-03-08T21:32:25Z

Create the infraestructure folder with the 4 main files
(main.tf, prod.tfvars, stage.tfvars, variables.tf) and use
the organization private modules to deploy all the resources to
the ui need to deploy in the two enviroments (stage and prod)

Resolves: https://ioetec.atlassian.net/browse/TT-509

scoello

Looks very good. Please add the readme.md file

madinya

LGTM. keep in mind that you should also request a review from Fausto.

* feat: TT-580 Missing placeholders * feat: TT-580 add placeholders in ticket uri and description text inputs on the time clock page Co-authored-by: Luis Moyon <[email protected]>

* feat: TT-578 improve the style of the form element

…ck out button (#824) * style: TT-582 improve the summary section with a new row with information of actual clock in register and clock out button * fix: TT-582 add missing unit test to confirm that clockout function in TimeEntriesSummaryComponent emits an event * style: TT-582 add a border radius to current elapsed time box Co-authored-by: David Cadena <[email protected]>

* feat: TT-576 Improve grids visual presentation and function

scoello

Good job my friend!

madinya · 2022-03-16T20:42:36Z

Dockerfile

 RUN touch /var/run/nginx.pid && chown -R ${USERNAME}:${USERNAME} /var/run/nginx.pid

-USER ${USERNAME}
+#USER ${USERNAME}


If it is not needed anymore you can delete it

suggestion: Could your add a FIXME statement explaining why this has been commented out?

madinya

Reviewed with few comments

* feat: TT-577 get profile pic from Google account * feat: TT-577 get profile pic from Google account * feat: TT-577 get profile pic from Google account Co-authored-by: alejandra-ponce <[email protected]>

This reverts commit 3bee7e3. Co-authored-by: Carlos Carvajal <[email protected]>

faustocv · 2022-03-17T17:34:01Z

Dockerfile

 RUN touch /var/run/nginx.pid && chown -R ${USERNAME}:${USERNAME} /var/run/nginx.pid

-USER ${USERNAME}
+#USER ${USERNAME}


suggestion: Could your add a FIXME statement explaining why this has been commented out?

faustocv · 2022-03-17T17:39:19Z

infrastructure/main.tf

+  }
+}
+
+data "azurerm_container_registry" "registry" {


issue: I think this will make another unnecessary call to the azure API. The data.terraform_remote_state.service.outputs.container_registry_name already provides a valid reference to the container registry

really? i change that

faustocv · 2022-03-17T17:40:03Z

infrastructure/main.tf

+}
+
+data "azurerm_resource_group" "root" {
+  name = data.terraform_remote_state.service.outputs.resource_group_name


issue: Same issue as the one explained above

infrastructure/main.tf

faustocv · 2022-03-17T17:50:15Z

infrastructure/variables.tf

@@ -0,0 +1,17 @@
+variable "docker_image_name" {


issue: replace this with image_tag, something like https://github.com/ioet/time-tracker-v2/blob/255112b0f270ae17de84a20cd7791705dc573f8e/infrastructure/variables.tf#L7

in the docker_image_name i pass the name of the image and the tag this is because the module is configure in that way if i only put tag. I think can we drop in a confusion because tag is (:2.0.1) and docker_image for me its (timetracker:2.0.1)

* style: TT-582 improve the summary section with a new row with information of actual clock in register and clock out button * fix: TT-582 add missing unit test to confirm that clockout function in TimeEntriesSummaryComponent emits an event * style: TT-582 add a border radius to current elapsed time box * style: TT-582 improved the clocked in hour text and current time box * style: TT-582 improved the clocked in hour text and current time box * style: TT-582 removed whitespace Co-authored-by: Luis Moyón <[email protected]>

faustocv

Looks good now

sonarqubecloud · 2022-03-22T01:49:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov · 2022-03-22T01:52:38Z

Codecov Report

Merging #819 (df9071c) into master (95d1ed3) will increase coverage by 1.84%.
The diff coverage is 96.73%.

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   95.64%   97.48%   +1.84%     
==========================================
  Files         107      107              
  Lines        2273     2430     +157     
  Branches      175      203      +28     
==========================================
+ Hits         2174     2369     +195     
+ Misses         54       23      -31     
+ Partials       45       38       -7

Impacted Files	Coverage Δ
...er-management/store/customer-management.effects.ts	`100.00% <ø> (ø)`
src/environments/environment.ts	`100.00% <ø> (ø)`
...eate-project-type/create-project-type.component.ts	`96.96% <50.00%> (-3.04%)`	⬇️
...es/shared/interceptors/inject.token.interceptor.ts	`87.50% <66.66%> (-12.50%)`	⬇️
...c/app/modules/time-clock/services/entry.service.ts	`96.42% <75.00%> (-3.58%)`	⬇️
...p/modules/time-clock/pages/time-clock.component.ts	`96.42% <83.33%> (+4.76%)`	⬆️
...ts/projects/components/services/project.service.ts	`94.11% <85.71%> (+3.20%)`	⬆️
...project-list-hover/project-list-hover.component.ts	`90.90% <93.33%> (+0.16%)`	⬆️
src/app/modules/login/login.component.ts	`95.83% <93.75%> (-4.17%)`	⬇️
...ponents/details-fields/details-fields.component.ts	`98.08% <96.29%> (+1.68%)`	⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dafbcd...df9071c. Read the comment docs.

feat: TT-509 Use terraform to provision ui infraestructure

62d569b

jatobrun requested review from faustocv, mikevillarruel, santii90ec and scoello March 8, 2022 21:32

scoello reviewed Mar 9, 2022

View reviewed changes

jatobrun requested a review from madinya March 10, 2022 15:14

madinya approved these changes Mar 10, 2022

View reviewed changes

alejandra-ponce and others added 10 commits March 10, 2022 12:53

feat: TT-580 Missing placeholders (#820)

72cf8f7

* feat: TT-580 Missing placeholders * feat: TT-580 add placeholders in ticket uri and description text inputs on the time clock page Co-authored-by: Luis Moyon <[email protected]>

chore(release): 1.66.0 [skip ci]nn

a458f98

TT-xx: Fix make publish tasks (#822)

bf8977e

fix: TT-509 expose port 8080 in docker images

3fe4e5e

fix: TT-509 change app to port 80

6cc64e6

feat: TT-578 improve the style of the form element (#823)

4ee7c37

* feat: TT-578 improve the style of the form element

chore(release): 1.67.0 [skip ci]nn

482bfb1

fix: TT-509 including empty line in all files

483cf6a

fix: TT-509 Change the dockerfile to use root user and not app user

a4b8426

jatobrun requested a review from scoello March 16, 2022 15:01

iHackN3WTON and others added 2 commits March 16, 2022 10:07

feat: TT-576 Improve grids visual presentation and function (#826)

429c008

* feat: TT-576 Improve grids visual presentation and function

chore(release): 1.68.0 [skip ci]nn

24d7f40

scoello approved these changes Mar 16, 2022

View reviewed changes

madinya reviewed Mar 16, 2022

View reviewed changes

kjduy and others added 5 commits March 16, 2022 16:49

feat: TT-577 get profile pic from Google account (#825)

3bee7e3

* feat: TT-577 get profile pic from Google account * feat: TT-577 get profile pic from Google account * feat: TT-577 get profile pic from Google account Co-authored-by: alejandra-ponce <[email protected]>

chore(release): 1.69.0 [skip ci]nn

4c48be4

Revert "feat: TT-577 get profile pic from Google account (#825)" (#829)

98d092c

This reverts commit 3bee7e3. Co-authored-by: Carlos Carvajal <[email protected]>

chore(release): 1.69.1 [skip ci]nn

454b7f9

style: TT-579 Buttons and searchbar adjusted to the app style (#827)

ac17c44

faustocv reviewed Mar 17, 2022

View reviewed changes

alejandra-ponce and others added 5 commits March 17, 2022 13:02

fix: TT-590 unable to pass ci test (#831)

0b48625

chore(release): 1.69.2 [skip ci]nn

da50b7a

fix: TT-509 pr comments

97b6435

fix: TT-509 using remote state to load variables

8993fbc

jatobrun requested a review from faustocv March 18, 2022 23:54

jatobrun added 4 commits March 21, 2022 10:13

Update variables.tf

9c33cee

delete prefix docker

33096b5

delete prefix docker in locals block

37e64ee

fix: Update the values of the terraform state output

e0dc5f7

mikevillarruel removed their request for review March 21, 2022 16:34

faustocv approved these changes Mar 21, 2022

View reviewed changes

fix: resolve package-lock conflicts

df9071c

jatobrun merged commit 75e909a into master Mar 22, 2022

feat: TT-509 Use terraform to provision ui infraestructure #819

feat: TT-509 Use terraform to provision ui infraestructure #819

Uh oh!

Conversation

jatobrun commented Mar 8, 2022

Uh oh!

scoello left a comment

Choose a reason for hiding this comment

Uh oh!

madinya left a comment

Choose a reason for hiding this comment

Uh oh!

scoello left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madinya left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

faustocv left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 22, 2022

Uh oh!

codecov bot commented Mar 22, 2022

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants