Skip to content

feat: TT-576 Improve grids visual presentation and function #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

feat: TT-576 Improve grids visual presentation and function #826

merged 2 commits into from
Mar 16, 2022

Conversation

iHackN3WTON
Copy link
Collaborator

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #826 (3390b5b) into master (95d1ed3) will increase coverage by 1.76%.
The diff coverage is 95.86%.

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   95.64%   97.40%   +1.76%     
==========================================
  Files         107      107              
  Lines        2273     2430     +157     
  Branches      175      203      +28     
==========================================
+ Hits         2174     2367     +193     
+ Misses         54       23      -31     
+ Partials       45       40       -5
Impacted Files Coverage Δ
...er-management/store/customer-management.effects.ts 100.00% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
...eate-project-type/create-project-type.component.ts 96.96% <50.00%> (-3.04%) ⬇️
...es/shared/interceptors/inject.token.interceptor.ts 87.50% <66.66%> (-12.50%) ⬇️
...c/app/modules/time-clock/services/entry.service.ts 96.42% <75.00%> (-3.58%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 96.42% <83.33%> (+4.76%) ⬆️
...ts/projects/components/services/project.service.ts 94.11% <85.71%> (+3.20%) ⬆️
...shared/components/dark-mode/dark-mode.component.ts 90.90% <90.90%> (-4.55%) ⬇️
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
src/app/modules/login/login.component.ts 95.83% <93.75%> (-4.17%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482bfb1...3390b5b. Read the comment docs.

codigodehoy
codigodehoy approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@codigodehoy codigodehoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like great, but I recommend the arrow's color should be another color because, the title is already white and doesn't distinguishable

madinya
madinya approved these changes Mar 16, 2022
View reviewed changes
Copy link

@madinya madinya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iHackN3WTON iHackN3WTON merged commit 429c008 into master Mar 16, 2022
@iHackN3WTON iHackN3WTON deleted the TT-576-improve-grids-visual-presentation-and-functionability branch March 16, 2022 16:07
jatobrun added a commit that referenced this pull request Mar 22, 2022
@jatobrun @alejandra-ponce
@LuisMS7 @semantic-release-bot @faustocv @iHackN3WTON @codigodehoy @kjduy @cxcarvaj @MarcoAguirre @FreddyJR1995
feat: TT-509 Use terraform to provision ui infraestructure (#819)
75e909a 
* feat: TT-509 Use terraform to provision ui infraestructure

* feat: TT-580 Missing placeholders (#820)

* feat: TT-580 Missing placeholders

* feat: TT-580 add placeholders in ticket uri and description text inputs on the time clock page

Co-authored-by: Luis Moyon <[email protected]>

* chore(release): 1.66.0 [skip ci]nn

* TT-xx: Fix make publish tasks (#822)

* fix: TT-509 expose port 8080 in docker images

* fix: TT-509 change app to port 80

* feat: TT-578 improve the style of the form element (#823)

* feat: TT-578 improve the style of the form element

* chore(release): 1.67.0 [skip ci]nn

* TT-582 Improve the summary section of the time-clock page and the clock out button (#824)

* style: TT-582 improve the summary section with a new row with information of actual clock in register and clock out button

* fix: TT-582 add missing unit test to confirm that clockout function in TimeEntriesSummaryComponent emits an event

* style: TT-582 add a border radius to current elapsed time box

Co-authored-by: David Cadena <[email protected]>

* fix: TT-509 including empty line in all files

* fix: TT-509 Change the dockerfile to use root user and not app user

* feat: TT-576 Improve grids visual presentation and function (#826)

* feat: TT-576 Improve grids visual presentation and function

* chore(release): 1.68.0 [skip ci]nn

* feat: TT-577 get profile pic from Google account (#825)

* feat: TT-577 get profile pic from Google account

* feat: TT-577 get profile pic from Google account

* feat: TT-577 get profile pic from Google account

Co-authored-by: alejandra-ponce <[email protected]>

* chore(release): 1.69.0 [skip ci]nn

* Revert "feat: TT-577 get profile pic from Google account (#825)" (#829)

This reverts commit 3bee7e3.

Co-authored-by: Carlos Carvajal <[email protected]>

* chore(release): 1.69.1 [skip ci]nn

* style: TT-579 Buttons and searchbar adjusted to the app style (#827)

* fix: TT-590 unable to pass ci test (#831)

* chore(release): 1.69.2 [skip ci]nn

* Tt 582 improve the summary section of the time clock page QA (#830)

* style: TT-582 improve the summary section with a new row with information of actual clock in register and clock out button

* fix: TT-582 add missing unit test to confirm that clockout function in TimeEntriesSummaryComponent emits an event

* style: TT-582 add a border radius to current elapsed time box

* style: TT-582 improved the clocked in hour text and current time box

* style: TT-582 improved the clocked in hour text and current time box

* style: TT-582 removed whitespace

Co-authored-by: Luis Moyón <[email protected]>

* fix: TT-509 pr comments

* fix: TT-509 using remote state to load variables

* Update variables.tf

* delete prefix docker

* delete prefix docker in locals block

* fix: Update the values of the terraform state output

Co-authored-by: alejandra-ponce <[email protected]>
Co-authored-by: Luis Moyon <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Fausto Castaneda <[email protected]>
Co-authored-by: iHackN3WTON <[email protected]>
Co-authored-by: LuisMS7 <[email protected]>
Co-authored-by: David Cadena <[email protected]>
Co-authored-by: Kevin Joseph Duy Hurtado <[email protected]>
Co-authored-by: alejandra-ponce <[email protected]>
Co-authored-by: Carlos Carvajal <[email protected]>
Co-authored-by: MarcoAguirre <[email protected]>
Co-authored-by: FreddyJR1995 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@madinya madinya madinya approved these changes

@codigodehoy codigodehoy codigodehoy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iHackN3WTON @madinya @codigodehoy