Skip to content

feat: TT-578 improve the style of the form element #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2022
Merged

feat: TT-578 improve the style of the form element #823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aa847e
feat: TT-578 improve the style of the form element
iHackN3WTON Mar 11, 2022
f27bdfa
feat: TT-578 improve the style of the form element
iHackN3WTON Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/modules/shared/components/details-fields/details-fields.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
id="uri"
type="text"
placeholder="Enter Jira ticket URL"
class="form-control"
class="url-ticket-input form-control"
aria-label="Small"
aria-describedby="inputGroup-sizing-sm"
/>
Expand Down
11 changes: 11 additions & 0 deletions src/app/modules/shared/components/details-fields/details-fields.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,14 @@ input[type="date"]::-webkit-clear-button {
::ng-deep .cdk-overlay-container {
z-index: 1100 !important;
}

.url-ticket-input {
border: 1px solid #ced4da !important;
border-radius: 0.25rem !important;
}
Copy link
Contributor

@LuisMS7 LuisMS7 Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if the selector is .form-control.url-ticket-input to avoid the use of "!important".

Copy link
Collaborator Author

@iHackN3WTON iHackN3WTON Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's not necessary the !important tag, I'll remove it.


::ng-deep .ngx-timepicker {
border: 1px solid #ced4da !important;
border-radius: 0.25rem;
padding: 2px;
}
2 changes: 1 addition & 1 deletion src/app/modules/time-clock/components/entry-fields/entry-fields.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
placeholder="Enter Jira ticket URL"
id="uri"
formControlName="uri"
class="form-control"
class="url-ticket-input form-control"
/>
</div>

Expand Down
11 changes: 11 additions & 0 deletions src/app/modules/time-clock/components/entry-fields/entry-fields.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,14 @@
.hidden {
display: none;
}

.url-ticket-input {
border: 1px solid #ced4da;
border-radius: 0.25rem;
}

::ng-deep .ngx-timepicker {
border: 1px solid #ced4da;
border-radius: 0.25rem;
padding: 2px;
}
Copy link
Contributor

@LuisMS7 LuisMS7 Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a new line at the end of the file.