Skip to content

Conversation

jcalarcon98
Copy link
Contributor

Description

Currently there is an error with some entries that does not allow to modify their start or end time, the error that is generated is the following:
image

When attempting to modify the following entries:
image

This error occurs because in the current implementation to modify the entries they are not taking into account the seconds of the entries, in other words, only hours and minutes are taken into account.

Solution

With this PR, this implementation has been fixed and now takes into account all the information of the start/end time of the entry.

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #722 (2df4918) into master (13de42e) will increase coverage by 2.14%.
The diff coverage is 96.57%.

❗ Current head 2df4918 differs from pull request most recent head db3c22d. Consider uploading reports for the commit db3c22d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   93.09%   95.24%   +2.14%     
==========================================
  Files          85      106      +21     
  Lines        1564     2206     +642     
  Branches      107      169      +62     
==========================================
+ Hits         1456     2101     +645     
+ Misses         67       61       -6     
- Partials       41       44       +3     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 63.63% <60.00%> (+8.08%) ⬆️
...toggles/filters/feature-filter-provider.service.ts 80.00% <62.50%> (+2.22%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...dules/time-entries/pages/time-entries.component.ts 88.00% <90.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.66% <93.33%> (+12.45%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...-entries/components/calendar/calendar.component.ts 95.16% <95.16%> (ø)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8af2f...db3c22d. Read the comment docs.

@jcalarcon98 jcalarcon98 force-pushed the TT-311-can-not-update-time-entries branch from f4bd13f to db3c22d Compare August 16, 2021 16:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jcalarcon98 jcalarcon98 merged commit d937d24 into master Aug 16, 2021
@jcalarcon98 jcalarcon98 deleted the TT-311-can-not-update-time-entries branch August 16, 2021 17:22
ridouku added a commit that referenced this pull request Aug 16, 2021
* fix: TT-309 Implement static packages

* fix: TT-304 Handle message: the data could not be load (#716)

* fix: TT-304 Handle message: the data could not be load

* test: TT-304 Creating an unit test to coverage the new feature

Co-authored-by: Edgar Guaman <[email protected]>

* chore(release): 1.47.1 [skip ci]nn

* Revert "fix: TT-304 Handle message: the data could not be load (#716)" (#723)

This reverts commit d2fc2a0.

* chore(release): 1.47.2 [skip ci]nn

* fix: TT-309 Implement static packages

* fix: TT-311 Can not update entries fixed (#722)

* fix: TT-311 Can not update entries fixed

* code-smell: TT-311 Code smells suggested by Sonarcloud fixed

* fix: TT-311 Fix tests that fails on different timezone

* fix: TT-311 Spelling error on method fixed

* chore(release): 1.47.3 [skip ci]nn

* fix: TT-309 Implement static packages

Co-authored-by: Edgar David Guamán <[email protected]>
Co-authored-by: Edgar Guaman <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Sandro Castillo <[email protected]>
Co-authored-by: Jean Carlos Alarcón <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants