fix: TT-311 Can not update entries fixed#722
Merged
Merged
Conversation
jcalarcon98
requested review from
bytesantiago,
edgardavid2015,
kevinjlope,
ridouku and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
+ Coverage 93.09% 95.24% +2.14%
==========================================
Files 85 106 +21
Lines 1564 2206 +642
Branches 107 169 +62
==========================================
+ Hits 1456 2101 +645
+ Misses 67 61 -6
- Partials 41 44 +3
Continue to review full report at Codecov.
|
scastillo-jp
approved these changes
Aug 16, 2021
ridouku
suggested changes
Aug 16, 2021
ridouku
approved these changes
Aug 16, 2021
jcalarcon98
force-pushed
the
TT-311-can-not-update-time-entries
branch
from
f4bd13f to
db3c22d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bytesantiago
approved these changes
Aug 16, 2021
ridouku
added a commit
that referenced
this pull request
Aug 16, 2021
* fix: TT-309 Implement static packages * fix: TT-304 Handle message: the data could not be load (#716) * fix: TT-304 Handle message: the data could not be load * test: TT-304 Creating an unit test to coverage the new feature Co-authored-by: Edgar Guaman <edgar.guaman@ioet.com> * chore(release): 1.47.1 [skip ci]nn * Revert "fix: TT-304 Handle message: the data could not be load (#716)" (#723) This reverts commit d2fc2a0. * chore(release): 1.47.2 [skip ci]nn * fix: TT-309 Implement static packages * fix: TT-311 Can not update entries fixed (#722) * fix: TT-311 Can not update entries fixed * code-smell: TT-311 Code smells suggested by Sonarcloud fixed * fix: TT-311 Fix tests that fails on different timezone * fix: TT-311 Spelling error on method fixed * chore(release): 1.47.3 [skip ci]nn * fix: TT-309 Implement static packages Co-authored-by: Edgar David Guamán <edgardavid2015@users.noreply.github.com> Co-authored-by: Edgar Guaman <edgar.guaman@ioet.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Sandro Castillo <blosomsam@gmail.com> Co-authored-by: Jean Carlos Alarcón <56373098+jcalarcon98@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently there is an error with some entries that does not allow to modify their start or end time, the error that is generated is the following:
When attempting to modify the following entries:
This error occurs because in the current implementation to modify the entries they are not taking into account the seconds of the entries, in other words, only hours and minutes are taken into account.
Solution
With this PR, this implementation has been fixed and now takes into account all the information of the start/end time of the entry.