-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-311 Can not update entries fixed #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
+ Coverage 93.09% 95.24% +2.14%
==========================================
Files 85 106 +21
Lines 1564 2206 +642
Branches 107 169 +62
==========================================
+ Hits 1456 2101 +645
+ Misses 67 61 -6
- Partials 41 44 +3
Continue to review full report at Codecov.
|
src/app/modules/shared/components/details-fields/details-fields.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/details-fields/details-fields.component.ts
Show resolved
Hide resolved
src/app/modules/shared/components/details-fields/details-fields.component.ts
Show resolved
Hide resolved
src/app/modules/shared/components/details-fields/details-fields.component.ts
Show resolved
Hide resolved
src/app/modules/shared/components/details-fields/details-fields.component.ts
Show resolved
Hide resolved
src/app/modules/shared/components/details-fields/details-fields.component.spec.ts
Show resolved
Hide resolved
f4bd13f
to
db3c22d
Compare
Kudos, SonarCloud Quality Gate passed!
|
* fix: TT-309 Implement static packages * fix: TT-304 Handle message: the data could not be load (#716) * fix: TT-304 Handle message: the data could not be load * test: TT-304 Creating an unit test to coverage the new feature Co-authored-by: Edgar Guaman <[email protected]> * chore(release): 1.47.1 [skip ci]nn * Revert "fix: TT-304 Handle message: the data could not be load (#716)" (#723) This reverts commit d2fc2a0. * chore(release): 1.47.2 [skip ci]nn * fix: TT-309 Implement static packages * fix: TT-311 Can not update entries fixed (#722) * fix: TT-311 Can not update entries fixed * code-smell: TT-311 Code smells suggested by Sonarcloud fixed * fix: TT-311 Fix tests that fails on different timezone * fix: TT-311 Spelling error on method fixed * chore(release): 1.47.3 [skip ci]nn * fix: TT-309 Implement static packages Co-authored-by: Edgar David Guamán <[email protected]> Co-authored-by: Edgar Guaman <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Sandro Castillo <[email protected]> Co-authored-by: Jean Carlos Alarcón <[email protected]>
Description
Currently there is an error with some entries that does not allow to modify their start or end time, the error that is generated is the following:

When attempting to modify the following entries:

This error occurs because in the current implementation to modify the entries they are not taking into account the seconds of the entries, in other words, only hours and minutes are taken into account.
Solution
With this PR, this implementation has been fixed and now takes into account all the information of the start/end time of the entry.