fix: TT-304 Handle message: the data could not be load#716
Merged
edgardavid2015 merged 2 commits intoAug 13, 2021
Conversation
edgardavid2015
requested review from
JosueOb,
bytesantiago,
jcalarcon98,
ridouku and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 93.09% 95.09% +2.00%
==========================================
Files 85 106 +21
Lines 1564 2204 +640
Branches 107 168 +61
==========================================
+ Hits 1456 2096 +640
+ Misses 67 64 -3
- Partials 41 44 +3
Continue to review full report at Codecov.
|
edgardavid2015
force-pushed
the
TT-304-Handle-message-the-data-could-not-be-load
branch
from
8d6aac4 to
ae1eaee
Compare
bytesantiago
approved these changes
Aug 12, 2021
scastillo-jp
approved these changes
Aug 13, 2021
edgardavid2015
force-pushed
the
TT-304-Handle-message-the-data-could-not-be-load
branch
from
ae1eaee to
afc51c1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
edgardavid2015
deleted the
TT-304-Handle-message-the-data-could-not-be-load
branch
scastillo-jp
added a commit
that referenced
this pull request
Aug 16, 2021
This reverts commit d2fc2a0.
scastillo-jp
added a commit
that referenced
this pull request
Aug 16, 2021
ridouku
added a commit
that referenced
this pull request
Aug 16, 2021
* fix: TT-309 Implement static packages * fix: TT-304 Handle message: the data could not be load (#716) * fix: TT-304 Handle message: the data could not be load * test: TT-304 Creating an unit test to coverage the new feature Co-authored-by: Edgar Guaman <edgar.guaman@ioet.com> * chore(release): 1.47.1 [skip ci]nn * Revert "fix: TT-304 Handle message: the data could not be load (#716)" (#723) This reverts commit d2fc2a0. * chore(release): 1.47.2 [skip ci]nn * fix: TT-309 Implement static packages * fix: TT-311 Can not update entries fixed (#722) * fix: TT-311 Can not update entries fixed * code-smell: TT-311 Code smells suggested by Sonarcloud fixed * fix: TT-311 Fix tests that fails on different timezone * fix: TT-311 Spelling error on method fixed * chore(release): 1.47.3 [skip ci]nn * fix: TT-309 Implement static packages Co-authored-by: Edgar David Guamán <edgardavid2015@users.noreply.github.com> Co-authored-by: Edgar Guaman <edgar.guaman@ioet.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Sandro Castillo <blosomsam@gmail.com> Co-authored-by: Jean Carlos Alarcón <56373098+jcalarcon98@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the time-entries section, when there is no data, the message "The data could not be load" is displayed.
Solution
When there is no data, the message "The data could not be load" must not be displayed, instead the message "No data available in table" should be displayed in the table section. That is the purpose of this pull request.
