fix: TT-309 Implement static packages #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridouku
requested review from
edgardavid2015,
scastillo-jp,
bytesantiago and
jcalarcon98
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
==========================================
+ Coverage 93.09% 95.24% +2.14%
==========================================
Files 85 106 +21
Lines 1564 2206 +642
Branches 107 169 +62
==========================================
+ Hits 1456 2101 +645
+ Misses 67 61 -6
- Partials 41 44 +3
Continue to review full report at Codecov.
|
* fix: TT-304 Handle message: the data could not be load * test: TT-304 Creating an unit test to coverage the new feature Co-authored-by: Edgar Guaman <[email protected]>
jcalarcon98
approved these changes
Aug 15, 2021
edgardavid2015
approved these changes
Aug 16, 2021
bytesantiago
approved these changes
Aug 16, 2021
…me-tracker-ui into TT-309-Implement-static-packages
* fix: TT-311 Can not update entries fixed * code-smell: TT-311 Code smells suggested by Sonarcloud fixed * fix: TT-311 Fix tests that fails on different timezone * fix: TT-311 Spelling error on method fixed
…me-tracker-ui into TT-309-Implement-static-packages
|
Kudos, SonarCloud Quality Gate passed!
|
scastillo-jp
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the project works without pinned dependencies, therefore there are inconsistencies between environments and troubles when a merge between a new branch with master is required the package-lock.json has many inconsistencies because the dependencies has caret or tilde symbol in their version and this allows to install patch o new features.
Solution
This PR modified the package.json to pin dependencies and prevent the inconsistencies, some dependencies were not change to static version and is required a future revision.