Skip to content

fix: TT-311 Can not update entries fixed #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2021
Merged

fix: TT-311 Can not update entries fixed #722

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
523084e
fix: TT-311 Can not update entries fixed
jcalarcon98 Aug 14, 2021
9e3c7a8
code-smell: TT-311 Code smells suggested by Sonarcloud fixed
jcalarcon98 Aug 15, 2021
72b6a60
fix: TT-311 Fix tests that fails on different timezone
jcalarcon98 Aug 16, 2021
db3c22d
fix: TT-311 Spelling error on method fixed
jcalarcon98 Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code-smell: TT-311 Code smells suggested by Sonarcloud fixed
  • Loading branch information
@jcalarcon98
jcalarcon98 committed Aug 16, 2021
commit 9e3c7a8e0ad883e3b6e497bfdbf00124044d364e
6 changes: 2 additions & 4 deletions src/app/modules/shared/components/details-fields/details-fields.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,15 +269,13 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
const secondsInISOFormat: string = this.getNumberInISOFornat(seconds);
const milisecondsInISOFormat: string = this.getNumberInISOFornat(miliseconds);
const ISOFormat = `${date}T${hourAndMinutes}:${secondsInISOFormat}.${milisecondsInISOFormat}`;
const dateISOFormat: string = new Date(ISOFormat).toISOString();
return dateISOFormat;
return new Date(ISOFormat).toISOString();
}

getNumberInISOFornat(numberToFormat: number): string {
const limitSingleNumber = 9;
const isNumberGreaterThanLimitNumber = numberToFormat > limitSingleNumber;
const numberInISOFormat: string = isNumberGreaterThanLimitNumber ? numberToFormat.toString() : `0${numberToFormat}`;
return numberInISOFormat;
return isNumberGreaterThanLimitNumber ? numberToFormat.toString() : `0${numberToFormat}`;
}

dateToSubmit(date: string, hour: string) {
Expand Down