fix: Don't expose existing emails via reset password and account creation forms - #5254
fix: Don't expose existing emails via reset password and account creation forms#5254larseggert wants to merge 27 commits into
Conversation
larseggert
changed the title
larseggert
changed the title
* fix: Link to IPR details not history in email Fixes ietf-tools#5251 * Fix test
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
Ah - needs a new test that exercises sending the new email.
Codecov Report
@@ Coverage Diff @@
## feat/postgres #5254 +/- ##
=================================================
+ Coverage 88.47% 88.58% +0.10%
=================================================
Files 296 294 -2
Lines 39805 40071 +266
=================================================
+ Hits 35219 35496 +277
+ Misses 4586 4575 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…s#5262) * fix: Don't offer already-disabled API keys for disablement Fixes ietf-tools#3441 * Remove test class
) * fix: Truncate text agenda labels to not overflow colums Also tweak the spacing some and add a guard for an undefined field. Fixes ietf-tools#1313 * Fix test
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Comments inline - one trivial, one substantive.
…tf-tools#5279) * fix: Add footer with group interim ics calendar to announce email Fixes ietf-tools#2939 * Fix test
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
I have been making changes in feat/postgres around this code, and there is a bunch that will have to change with what you're proposing now if we were to bring it into main and then merge it to postgres. It's painful, and I'm sorry to ask, but could you rebase your branch on feat/postgres and target the PR there instead?
…nfo (ietf-tools#5265) * fix: Add missing closing brace in meta tag Fixes ietf-tools#3379 * Also fix "obsoleted by" meta information * name -> canonical_name
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
lgtm, but @rjsparks mentioned wanting the PR pointed at feat/postgres
|
Yep, that is next. Wanted to make sure the basic logic is OK now though. |
ietf-tools#5282) * fix: Always label agenda session headers with day in meeting time zone * test: Test day labeling on agenda session header when changing tz * test: Label timeslot, not session, as 'Session I' etc for agenda tests
|
I messed up the rebase and had to do a clean PR. See #5288. |
4 participants
Fixes #5156