fix: Add missing closing brace in meta tag and updated/obsoleted-by info - #5265
Merged
Conversation
rjsparks
approved these changes
Mar 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #5265 +/- ##
==========================================
- Coverage 88.58% 88.57% -0.01%
==========================================
Files 295 294 -1
Lines 40114 40071 -43
==========================================
- Hits 35534 35493 -41
+ Misses 4580 4578 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
larseggert
changed the title
rjsparks
requested changes
Mar 2, 2023
| <meta name="description" | ||
| {% if not snapshot and doc.get_state_slug == 'rfc' %} | ||
| content="{{ doc.title }} (RFC {{ doc.rfc_number }}{% if published %}, {{ published.time|date:'F Y' }}{% endif %}{% if obsoleted_by %}; obsoleted by {{ obsoleted_by|join:', ' }}{% endif %}" | ||
| content="{{ doc.title }} (RFC {{ doc.rfc_number }}{% if published %}, {{ published.time|date:'F Y' }}{% endif %}{% if obsoleted_by %}; obsoleted by {% for rel in obsoleted_by %}{{ rel.source.name|prettystdname}}{% if not forloop.last%}, {% endif %}{% endfor %}{% endif %})" |
Member
There was a problem hiding this comment.
This isn't quite right yet. For RFC8889, we get:
<meta name="description"
content="Multipoint Alternate-Marking Method for Passive and Hybrid Performance Monitoring (RFC 8889, August 2020; obsoleted by draft-ietf-ippm-rfc8889bis)"
>
where instead of draft-ietf-ippm-rfc8889bis we should be getting RFC 9342
rjsparks
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3379