fix: Don't expose existing emails via reset password and account creation forms - #5288
Merged
Merged
Conversation
rjsparks
requested changes
Mar 7, 2023
Member
|
Thank you for the rebase effort |
rjsparks
approved these changes
Mar 14, 2023
jennifer-richards
approved these changes
Mar 15, 2023
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
Looks ok - I think it will leak the existence of an email / username in the case that the user has no active email addresses, but I think that's probably not an exploitable situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #5254. Rebase to feat/postgres.