Add browser-tracker-core default for os_timezone - #1338
Merged
Jethro Nederhof (jethron) merged 1 commit intoSep 2, 2024
Conversation
Jethro Nederhof (jethron)
requested a review
from Matus Tomlein (matus-tomlein)
August 30, 2024 04:59
BundleMonFiles added (6)
Total files change +106.57KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Matus Tomlein (matus-tomlein)
approved these changes
Aug 30, 2024
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 25, 2024
Merged
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a more lightweight way for the browser-tracker to get a value for the
os_timezone/tzfield that doesn't rely on the usual Timezone plugin.The Timezone plugin is very data-heavy, and when minified is currently the 4th largest plugin we distribute, but populates only this single field:
That plugin is no longer included by default in the
sp.jsbuild, and from my observations, rarely used when people use thebrowser-trackerdirectly, likely due to its size.I think this value is valuable to have as a datapoint, because it enables using the
derived_tstampto actually measure the "time of day" a user is on a site without having to guess based on the region determined via GeoIP.This adds a default to the tracker that should provide a good estimate for this value even without the use of the Timezone plugin, based on the configured timezone information available via the Internationalization API.
If the Timezone plugin is in use, it will override the value with whatever it determines.