Skip to content

Add browser-tracker-core default for os_timezone #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jethro Nederhof (jethron) merged 1 commit into from
Sep 2, 2024
Merged

Add browser-tracker-core default for os_timezone #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@snowplow/browser-tracker-core/ostz_default_2024-08-30-04-14.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-tracker-core",
"comment": "Add browser-tracker-core default for os_timezone",
"type": "none"
}
],
"packageName": "@snowplow/browser-tracker-core"
}
12 changes: 12 additions & 0 deletions libraries/browser-tracker-core/src/helpers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ export function isFunction(func: unknown) {
return false;
}

/**
* Lightweight configured runtime timezone detection
* @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/resolvedOptions#getting_the_users_time_zone_and_locale_preferences
* @returns IANA timezone name of current runtime preference
*/
export function getTimeZone(): string | void {
if (typeof Intl === 'object' && typeof Intl.DateTimeFormat === 'function') {
const systemPreferences = new Intl.DateTimeFormat().resolvedOptions();
return systemPreferences.timeZone;
}
}

/**
* Cleans up the page title
*/
Expand Down
3 changes: 3 additions & 0 deletions libraries/browser-tracker-core/src/tracker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
attemptGetSessionStorage,
attemptWriteSessionStorage,
createCrossDomainParameterValue,
getTimeZone,
} from '../helpers';
import { BrowserPlugin } from '../plugins';
import { newOutQueue } from './out_queue';
Expand Down Expand Up @@ -306,6 +307,7 @@ export function Tracker(
}

const { browserLanguage, resolution, colorDepth, cookiesEnabled } = getBrowserProperties();
const timeZone = getTimeZone();

// Set up unchanging name-value pairs
core.setTrackerVersion(version);
Expand All @@ -317,6 +319,7 @@ export function Tracker(
core.addPayloadPair('lang', browserLanguage);
core.addPayloadPair('res', resolution);
core.addPayloadPair('cd', colorDepth);
if (timeZone) core.addPayloadPair('tz', timeZone);

/*
* Initialize tracker
Expand Down