Skip to content

Remove browser-features, optimizely, ecommerce and consent plugins, deprecate enhanced ecommerce and performance timing plugins and add web vitals by default - #1345

Merged
Matus Tomlein (matus-tomlein) merged 15 commits into
release/4.0.0from
issue/remove_deprecated_plugins
Oct 1, 2024
Merged

Remove browser-features, optimizely, ecommerce and consent plugins, deprecate enhanced ecommerce and performance timing plugins and add web vitals by default#1345
Matus Tomlein (matus-tomlein) merged 15 commits into
release/4.0.0from
issue/remove_deprecated_plugins

Conversation

@matus-tomlein

@matus-tomlein Matus Tomlein (matus-tomlein) commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

This PR revises the plugins in the v4 release. The goals are:

  1. Make it more straightforward for customers to choose the correct plugins (so they don't have to choose from 3 ecommerce plugins and steer towards the ones supported by our dbt packages)
  2. Remove old plugins that build on deprecated APIs (e.g., optimizely)

Below is the list of changes. This is still open for discussion if you have a different opinion!

Removed plugins

  • browser-features
    • has already been deprecated in v3
  • optimizely
    • builds on deprecated optimizely APIs
  • ecommerce
    • we don't support it in our dbt packages, superseded by snowplow-ecommerce
  • consent
    • superseded by enhanced-consent, not sure if there is value in just deprecating?

Deprecated plugins

  • enhanced ecommerce
    • I thought that since this one reflect's the GA Enhanced Ecommerce, it's worth keeping it, but happy to remove as well
  • performance timing
    • was considering removing this but it is currently the most downloaded plugin on NPM and although most of the APIs it builds on are deprecated, not all

Added default plugins in sp.js

  • web vitals (needs configuration to be enabled)

Removed default plugins in sp.js

  • optimizely-x
  • timezone

Other changes

  • Add an option to enable performance navigation timing

@matus-tomlein Matus Tomlein (matus-tomlein) changed the title Issue/remove deprecated plugins Remove browser-features, optimizely, ecommerce and consent plugins, deprecate enhanced ecommerce and performance timing plugins and add web vitals by default Sep 25, 2024
@bundlemon

bundlemon Bot commented Sep 25, 2024

Copy link
Copy Markdown

BundleMon

Files added (6)
Status Path Size Limits
trackers/javascript-tracker/dist/sp.js
+23.86KB 30KB / +10%
libraries/browser-tracker-core/dist/index.mod
ule.js
+22.49KB 25KB / +10%
libraries/tracker-core/dist/index.module.js
+19.12KB 20KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+16.87KB 20KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+16.83KB 20KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.49KB 5KB / +10%

Total files change +102.66KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@igneel64 Peter Perlepes (igneel64) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jethron Jethro Nederhof (jethron) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer consent and ecommerce stick around as deprecated while they're still "not deprecated" and first-class (or the only built-in option) in other platform's trackers. But not a hill I'd die on.

Comment thread trackers/javascript-tracker/test/integration/integration.test.ts
Comment thread trackers/javascript-tracker/src/features.ts Outdated
Comment thread trackers/javascript-tracker/tracker.config.ts Outdated

@jethron Jethro Nederhof (jethron) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matus-tomlein
Matus Tomlein (matus-tomlein) merged commit bba7aa4 into release/4.0.0 Oct 1, 2024
@matus-tomlein
Matus Tomlein (matus-tomlein) deleted the issue/remove_deprecated_plugins branch October 1, 2024 06:04
Matus Tomlein (matus-tomlein) added a commit that referenced this pull request Oct 25, 2024
…eprecate enhanced ecommerce and performance timing plugins and add web vitals by default (#1345)

Removed plugins
- browser-features
- optimizely
- ecommerce
- consent

Deprecated plugins
- enhanced ecommerce
- performance timing

Added default plugins in sp.js
- web vitals (needs configuration to be enabled)

Removed default plugins in sp.js
- optimizely-x
- timezone

 Other changes
- Add an option to enable performance navigation timing
Matus Tomlein (matus-tomlein) added a commit that referenced this pull request Oct 28, 2024
…eprecate enhanced ecommerce and performance timing plugins and add web vitals by default (#1345)

Removed plugins
- browser-features
- optimizely
- ecommerce
- consent

Deprecated plugins
- enhanced ecommerce
- performance timing

Added default plugins in sp.js
- web vitals (needs configuration to be enabled)

Removed default plugins in sp.js
- optimizely-x
- timezone

 Other changes
- Add an option to enable performance navigation timing
Matus Tomlein (matus-tomlein) added a commit that referenced this pull request Oct 28, 2024
…eprecate enhanced ecommerce and performance timing plugins and add web vitals by default (#1345)

Removed plugins
- browser-features
- optimizely
- ecommerce
- consent

Deprecated plugins
- enhanced ecommerce
- performance timing

Added default plugins in sp.js
- web vitals (needs configuration to be enabled)

Removed default plugins in sp.js
- optimizely-x
- timezone

 Other changes
- Add an option to enable performance navigation timing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants