-
Notifications
You must be signed in to change notification settings - Fork 30
Remove references to AppCache #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| </IfModule> | ||
|
|
||
| AddType text/cache-manifest .manifest | ||
| AddType text/cache-manifest .appcache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should drop this entire file. it doesn't get used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I suppose it's leftover from a time this was once served by Apache. Deleted.
fd2e9d9 to
784110a
Compare
|
|
||
| // if for some reason, applicationCache is not working, load the app after a 3s timeout | ||
| // load the app after a 3s timeout | ||
| var initTimer = setTimeout(trackerInit, 3000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering - what if we just load straight away without a timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, the splash screen won't be seen. Do you want to remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I guess we lose our sponsorship logos.... @darksidelemm there's probably little reason to wait 3 seconds at startup, but we'd a better way of doing sponsorship stuff... happy to keep it for the time being but something maybe we should think about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@argilo lets leave it in the for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you decide to keep the splash screen, a useful improvement would be to let the rest of the app initialize behind it. At present, things like map tiles and telemetry don't even begin loading until the splash screen disappears.
AppCache is deprecated and support has been removed from browsers. AppCache functionality has been removed from sondehub-tracker as well, so we may as well clean up the last few references to it.