Skip to content

Conversation

@argilo
Copy link

@argilo argilo commented Oct 17, 2024

AppCache is deprecated and support has been removed from browsers. AppCache functionality has been removed from sondehub-tracker as well, so we may as well clean up the last few references to it.

</IfModule>

AddType text/cache-manifest .manifest
AddType text/cache-manifest .appcache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop this entire file. it doesn't get used

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I suppose it's leftover from a time this was once served by Apache. Deleted.


// if for some reason, applicationCache is not working, load the app after a 3s timeout
// load the app after a 3s timeout
var initTimer = setTimeout(trackerInit, 3000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering - what if we just load straight away without a timeout?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, the splash screen won't be seen. Do you want to remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess we lose our sponsorship logos.... @darksidelemm there's probably little reason to wait 3 seconds at startup, but we'd a better way of doing sponsorship stuff... happy to keep it for the time being but something maybe we should think about?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@argilo lets leave it in the for the time being.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you decide to keep the splash screen, a useful improvement would be to let the rest of the app initialize behind it. At present, things like map tiles and telemetry don't even begin loading until the splash screen disappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants