Skip to content

Remove references to AppCache #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheSkorm merged 1 commit into from
Nov 20, 2024
Merged

Remove references to AppCache #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@
/index.html
/service-worker.js
/js/version.json
cache.manifest
tiles/
38 changes: 0 additions & 38 deletions .htaccess
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ function trackerInit() {
if(!map) load();
}

// if for some reason, applicationCache is not working, load the app after a 3s timeout
// load the app after a 3s timeout
var initTimer = setTimeout(trackerInit, 3000);
Copy link
Member

@TheSkorm TheSkorm Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering - what if we just load straight away without a timeout?

Copy link
Author

@argilo argilo Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, the splash screen won't be seen. Do you want to remove it?

Copy link
Member

@TheSkorm TheSkorm Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess we lose our sponsorship logos.... @darksidelemm there's probably little reason to wait 3 seconds at startup, but we'd a better way of doing sponsorship stuff... happy to keep it for the time being but something maybe we should think about?

Copy link
Member

@TheSkorm TheSkorm Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@argilo lets leave it in the for the time being.

Copy link
Author

@argilo argilo Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you decide to keep the splash screen, a useful improvement would be to let the rest of the app initialize behind it. At present, things like map tiles and telemetry don't even begin loading until the splash screen disappears.


var listScroll;
Expand Down