Skip to content

Conversation

argilo
Copy link
Contributor

@argilo argilo commented Oct 15, 2024

This is a port of projecthorus/sondehub-tracker#341.

So far I have only performed cursory testing. Someone more familiar with the project should probably have a closer look before merging this.

@argilo
Copy link
Contributor Author

argilo commented Oct 15, 2024

Hold off on merging this for now, since I'll need to pull in projecthorus/sondehub-tracker#353 as well, once it's reviewed.

@argilo argilo marked this pull request as draft October 15, 2024 19:03
@argilo argilo force-pushed the remove-yui-compressor branch from 1631ab1 to 2ae2911 Compare October 17, 2024 06:19
@argilo
Copy link
Contributor Author

argilo commented Oct 17, 2024

I've now incorporated projecthorus/sondehub-tracker#353 and projecthorus/sondehub-tracker#356 here as well.

@argilo argilo marked this pull request as ready for review October 17, 2024 06:21
@darksidelemm
Copy link
Member

Hmm, did I merge things in the wrong order?

@argilo argilo force-pushed the remove-yui-compressor branch from 2ae2911 to 2c86e40 Compare October 17, 2024 13:06
@argilo
Copy link
Contributor Author

argilo commented Oct 17, 2024

No, a couple of the pull requests touched the same files, so conflicts were inevitable.

I rebased this one to resolve the conflict.

@darksidelemm darksidelemm merged commit 2a9a8b8 into projecthorus:testing Oct 17, 2024
@argilo argilo deleted the remove-yui-compressor branch October 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants