Fix PWA caching #353
Merged
Fix PWA caching #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It looks like PWA updates are working now. I had testing.v2.sondehub.org installed as a PWA on my phone, and it updated today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #341 I made
service-worker.jsstatic, but I realized after the fact that this will likely break PWA updating, because devices check for updates by looking for changes inmanifest.jsonorservice-worker.js.Here I've switched back to a templated
service-worker.js, which is generated fromservice-worker.template.js.Additionally, I realized that there wasn't match point having the now-static
app.jspull the version information fromindex.htmland dump it back in, so I moved that information directly intoindex.html.