Skip to content

Conversation

@ararcos
Copy link
Collaborator

@ararcos ararcos commented Dec 2, 2021

Problem
Whenever a user enters in the Time Clock>Projects, they have to type in a project for the feature to show a message.

image

the message of the technologies is not clear and new users do not understand how it works
image

Solution
when it is a new user, all available projects are displayed and when it is an old user, only the old projects are displayed.

image

improved help text of technologi
image

@ararcos ararcos requested review from Jobzi and mandres2015 December 2, 2021 15:57
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #770 (e82575d) into master (95d1ed3) will increase coverage by 0.09%.
The diff coverage is 96.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   95.64%   95.74%   +0.09%     
==========================================
  Files         107      106       -1     
  Lines        2273     2325      +52     
  Branches      175      181       +6     
==========================================
+ Hits         2174     2226      +52     
+ Misses         54       53       -1     
- Partials       45       46       +1     
Impacted Files Coverage Δ
...anagement/pages/activities-management.component.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 87.87% <80.00%> (-2.87%) ⬇️
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
...nents/projects/components/store/project.effects.ts 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950e4c7...e82575d. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ararcos ararcos merged commit 3f0c210 into master Dec 2, 2021
@ararcos ararcos deleted the TT-413-Improve-select-projects branch December 2, 2021 21:18
mandres2015 pushed a commit that referenced this pull request Dec 3, 2021
)

* fix: TT-413 show projects when you do not have the latest projects

* fix: TT-413 validate array empty
mandres2015 added a commit that referenced this pull request Dec 3, 2021
* feature: TT-430 list and edit status of activities

* feature: TT-430 hide add new activity in production

* feat: TT-430 tests added and environment production enabled

* feat: TT-430 column status change in prod or dev mode and delete is managed in backend

* fix: TT-413 show projects when you do not have the latest projects (#770)

* fix: TT-413 show projects when you do not have the latest projects

* fix: TT-413 validate array empty

* chore(release): 1.52.6 [skip ci]nn

* feat: TT-430 tests added and environment production enabled

* fix: TT-430 rebase with master

Co-authored-by: Alexander Rafael Arcos Gómez <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants