Skip to content

fix: TT-413 show projects when you do not have the latest projects #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2021
Merged

fix: TT-413 show projects when you do not have the latest projects #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78ecc0c
fix: TT-413 show projects when you do not have the latest projects
ararcos Dec 1, 2021
e82575d
fix: TT-413 validate array empty
ararcos Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/modules/shared/components/details-fields/details-fields.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,17 +161,17 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
this.store.dispatch(new projectActions.LoadProjects());
const recentProjects$ = this.store.pipe(select(getRecentProjects));
recentProjects$.subscribe((projects) => {
if (projects) {
this.listRecentProjects = [];
this.listRecentProjects = [];
if (projects?.length > 0) {
projects.forEach((project) => {
const projectWithSearchField = { ...project };
projectWithSearchField.search_field = `${project.customer.name} - ${project.name}`;
this.listRecentProjects.push(projectWithSearchField);
});
this.listProjectsShowed = this.listRecentProjects;
}else{
this.listRecentProjects = this.listProjects;
}
this.listProjectsShowed = this.listRecentProjects;
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/app/modules/shared/components/technologies/technologies.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class TechnologiesComponent implements OnInit, OnDestroy {
readonly ALLOW_SELECT_MULTIPLE = true;
readonly ALLOW_SEARCH = true;
readonly MIN_SEARCH_TERM_LENGTH = 2;
readonly TYPE_TO_SEARCH_TEXT = 'Please enter 2 or more characters';
readonly TYPE_TO_SEARCH_TEXT = 'Please enter 2 or more characters to search for technologies ';
readonly WAITING_TIME_AFTER_KEY_UP = 400;

isLoading = false;
Expand Down
4 changes: 2 additions & 2 deletions src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
this.store.dispatch(new actions.LoadProjects());
const recentProjects$ = this.store.pipe(select(getRecentProjects));
this.recentProjectsSubscription = recentProjects$.subscribe((projects) => {
if (projects) {
if (projects?.length > 0) {
this.listRecentProjects = projects;
this.listProjectsShowed = this.listRecentProjects;
}else{
this.listRecentProjects = this.listProjects;
}
this.listProjectsShowed = this.listRecentProjects;
});

this.updateEntrySubscription = this.actionsSubject$
Expand Down