Skip to content

Conversation

@mandres2015
Copy link
Collaborator

In this PR disabled add new activity in production and enabled in development, added list activities with V2 backend, fixed environment variables for run frontend in production

@mandres2015 mandres2015 requested a review from ararcos December 2, 2021 16:15
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #771 (11c781c) into master (95d1ed3) will increase coverage by 0.01%.
The diff coverage is 94.91%.

❗ Current head 11c781c differs from pull request most recent head 8fc28ce. Consider uploading reports for the commit 8fc28ce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   95.64%   95.66%   +0.01%     
==========================================
  Files         107      106       -1     
  Lines        2273     2329      +56     
  Branches      175      182       +7     
==========================================
+ Hits         2174     2228      +54     
  Misses         54       54              
- Partials       45       47       +2     
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...anagement/pages/activities-management.component.ts 60.00% <60.00%> (-40.00%) ⬇️
...project-list-hover/project-list-hover.component.ts 87.87% <80.00%> (-2.87%) ⬇️
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
...nents/projects/components/store/project.effects.ts 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950e4c7...8fc28ce. Read the comment docs.

@mandres2015 mandres2015 force-pushed the TT-430-Read-Activities-Localhost branch from ff0c67c to edaae8f Compare December 2, 2021 16:22
@mandres2015 mandres2015 force-pushed the TT-430-Read-Activities-Localhost branch from e6cac26 to 8fc28ce Compare December 3, 2021 18:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@mandres2015 mandres2015 merged commit e5431bc into master Dec 3, 2021
@mandres2015 mandres2015 deleted the TT-430-Read-Activities-Localhost branch December 3, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants