Skip to content

Conversation

edgardavid2015
Copy link
Contributor

Problem

The Duration column format inside the Reports section is not correct. This format is presenting the data in hours and minutes.

wrong_duration_format

Solution

This pull request retrieves the previous format of the Duration column. This format displays the data in hours or multiples of hours.

correct_duration_format

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #749 (ebbcd8d) into master (95d1ed3) will increase coverage by 0.08%.
The diff coverage is 97.05%.

❗ Current head ebbcd8d differs from pull request most recent head c231988. Consider uploading reports for the commit c231988 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   95.64%   95.73%   +0.08%     
==========================================
  Files         107      107              
  Lines        2273     2273              
  Branches      175      176       +1     
==========================================
+ Hits         2174     2176       +2     
+ Misses         54       52       -2     
  Partials       45       45              
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...time-entries-table/time-entries-table.component.ts 80.00% <100.00%> (+2.22%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 100.00% <100.00%> (+9.52%) ⬆️
...p/modules/shared/components/user/user.component.ts 100.00% <100.00%> (ø)
src/environments/enum.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b50b6c...c231988. Read the comment docs.

Copy link
Collaborator

@faustocv faustocv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it has room for improvement

@edgardavid2015 edgardavid2015 force-pushed the TT-336-Fix-format-Duration-column branch from 5a54578 to 19bf35a Compare September 17, 2021 20:57
@faustocv faustocv self-requested a review September 17, 2021 22:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@faustocv faustocv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's looking better.

@edgardavid2015 edgardavid2015 merged commit 426106f into master Sep 18, 2021
@edgardavid2015 edgardavid2015 deleted the TT-336-Fix-format-Duration-column branch September 18, 2021 17:53
bytesantiago added a commit that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants