-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-336 Fix format Duration column #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
+ Coverage 95.64% 95.73% +0.08%
==========================================
Files 107 107
Lines 2273 2273
Branches 175 176 +1
==========================================
+ Hits 2174 2176 +2
+ Misses 54 52 -2
Partials 45 45
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but it has room for improvement
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
5a54578
to
19bf35a
Compare
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's looking better.
This reverts commit 426106f.
Problem
The Duration column format inside the Reports section is not correct. This format is presenting the data in hours and minutes.
Solution
This pull request retrieves the previous format of the Duration column. This format displays the data in hours or multiples of hours.