fix: TT-336 Fix format Duration column (#749)

* fix: TT-336 Fix format Duration column

* code-smell: TT-336 Fixing code smells and test coverage

* code-smell: TT-336 Fixing code smells

* fix: TT-336 Changes in time entries unit tests

* fix: TT-336 Changes in time entries unit tests

* fix: TT-336 Deleting a console.log

Co-authored-by: Edgar Guaman <[email protected]>

Author: edgardavid2015

src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts

@@ -12,6 +12,10 @@ describe('Reports Page', () => {
     let fixture: ComponentFixture<TimeEntriesTableComponent>;
     let store: MockStore<EntryState>;
     let getReportDataSourceSelectorMock;
+    let durationTime: number;
+    let row: number;
+    let node: number;
+    let decimalValidator: RegExp;
     const timeEntry: Entry = {
       id: '123',
       start_date: new Date(),
@@ -62,6 +66,13 @@ describe('Reports Page', () => {
       })
     );
 
+    beforeEach(() => {
+      durationTime = new Date().setHours(5, 30);
+      row = 0;
+      node = 0;
+      decimalValidator = /^\d+\.\d{0,2}$/;
+    });
+
     it('component should be created', async () => {
       expect(component).toBeTruthy();
     });
@@ -107,6 +118,17 @@ describe('Reports Page', () => {
       });
     });
 
+    it('The data should be displayed as a multiple of hour when column is equal to 3', () => {
+      const column = 3;
+
+      expect(component.bodyExportOptions(durationTime, row, column, node)).toMatch(decimalValidator);
+    });
+
+    it('The data should not be displayed as a multiple of hour when column is different of 3', () => {
+      const column = 4;
+      expect(component.bodyExportOptions(durationTime, row, column, node)).toBe(durationTime);
+    });
+
     afterEach(() => {
       fixture.destroy();
     });

src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts

@@ -2,6 +2,7 @@ import { formatDate } from '@angular/common';
 import { AfterViewInit, Component, OnDestroy, OnInit, ViewChild} from '@angular/core';
 import { select, Store } from '@ngrx/store';
 import { DataTableDirective } from 'angular-datatables';
+import * as moment from 'moment';
 import { Observable, Subject, Subscription } from 'rxjs';
 import { Entry } from 'src/app/modules/shared/models';
 import { DataSource } from 'src/app/modules/shared/models/data-source.model';
@@ -28,11 +29,21 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
       },
       {
         extend: 'excel',
+        exportOptions: {
+          format: {
+            body: this.bodyExportOptions
+          }
+        },
         text: 'Excel',
         filename: `time-entries-${formatDate(new Date(), 'MM_dd_yyyy-HH_mm', 'en')}`
       },
       {
         extend: 'csv',
+        exportOptions: {
+          format: {
+            body: this.bodyExportOptions
+          }
+        },
         text: 'CSV',
         filename: `time-entries-${formatDate(new Date(), 'MM_dd_yyyy-HH_mm', 'en')}`
       },
@@ -83,4 +94,9 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
     const regex = new RegExp('http*', 'g');
     return regex.test(uri);
   }
+
+  bodyExportOptions(data, row, column, node){
+    const durationColumnIndex = 3;
+    return column === durationColumnIndex ? moment.duration(data).asHours().toFixed(2) : data;
+  }
 }