code-smell: TT-336 Fixing code smells and test coverage

Author: Edgar Guaman

src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts

@@ -12,6 +12,7 @@ describe('Reports Page', () => {
     let fixture: ComponentFixture<TimeEntriesTableComponent>;
     let store: MockStore<EntryState>;
     let getReportDataSourceSelectorMock;
+    let durationTime: number;
     const timeEntry: Entry = {
       id: '123',
       start_date: new Date(),
@@ -62,6 +63,10 @@ describe('Reports Page', () => {
       })
     );
 
+    beforeEach(() => {
+      durationTime = new Date().setHours(5, 30);
+    });
+
     it('component should be created', async () => {
       expect(component).toBeTruthy();
     });
@@ -107,6 +112,14 @@ describe('Reports Page', () => {
       });
     });
 
+    it('The data should be displayed as a multiple of hour when column is equal to 3', () => {
+      expect(component.bodyExportOptions(durationTime, 0, 3, 0)).toMatch(/^[+-]?([0-9]+\.?[0-9]*|\.[0-9]+)$/);
+    });
+
+    it('The data should not be displayed as a multiple of hour when column is different of 3', () => {
+      expect(component.bodyExportOptions(durationTime, 0, 4, 0)).toBe(durationTime);
+    });
+
     afterEach(() => {
       fixture.destroy();
     });

src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts

@@ -31,11 +31,7 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
         extend: 'excel',
         exportOptions: {
           format: {
-            body: (data, row, column, node) => {
-              return column === 3 ?
-              moment.duration(data).asHours().toFixed(4).slice(0, -1) :
-              data;
-            },
+            body: this.bodyExportOptions
           }
         },
         text: 'Excel',
@@ -45,11 +41,7 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
         extend: 'csv',
         exportOptions: {
           format: {
-            body: (data, row, column, node) => {
-              return column === 3 ?
-              moment.duration(data).asHours().toFixed(4).slice(0, -1) :
-              data;
-            },
+            body: this.bodyExportOptions
           }
         },
         text: 'CSV',
@@ -102,4 +94,10 @@ export class TimeEntriesTableComponent implements OnInit, OnDestroy, AfterViewIn
     const regex = new RegExp('http*', 'g');
     return regex.test(uri);
   }
+
+  bodyExportOptions(data, row, column, node){
+    console.log(data);
+    const durationColumnIndex = 3;
+    return column === durationColumnIndex ? moment.duration(data).asHours().toFixed(2) : data;
+  }
 }