TT-317 remove feature manager service#739
Merged
Merged
Conversation
…ort.guard and their dependants
…17-Remove-FeatureManagerService
bytesantiago
requested review from
JosueOb,
edgardavid2015,
jcalarcon98,
ridouku and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 95.24% 95.54% +0.30%
==========================================
Files 106 106
Lines 2206 2247 +41
Branches 169 169
==========================================
+ Hits 2101 2147 +46
+ Misses 61 57 -4
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
* fix: TT-319 Fix calendar week and day view * refactor: TT-319 select first day of the month when select on calendar * refactor: TT-319 Change moment library with date Co-authored-by: Andrés Soto <edansrock>
scastillo-jp
approved these changes
Aug 30, 2021
… toggle ui-list-technologies (#736) * perf: TT-316 removal of ui-list-technologies toggle, technologies-report.guard and their dependants * code-smell: TT-316 remove comments and unnecessary variable assignments * code-smell: TT-316 removal of an additional unnecessary import
…com/ioet/time-tracker-ui into TT-317-Remove-FeatureManagerService
…com/ioet/time-tracker-ui into TT-317-Remove-FeatureManagerService
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
The main idea was to remove the FeatureManagerService service entirely, to avoid direct calls to Azure-toggles when reloading the Time-Tracker application in the browser. Instead, we shall use CookieService. Therefore, in principle, it was necessary to remove FeatureManagerService from everywhere it was used, and also the tests that included the service.
Observation and solution
It was not possible to remove FeatureManagerService entirely, because CookieService depended from it. However, by removing two methods from FeatureManagerService we are achieving our goal which is to avoid calling Azure-toggles every time we reload the webpage. Instead, with the current configuration, we call Azure-toggles just at login, and then, CookieService is used the rest of the session.