Tt 319 fix calendar day week view #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdansRocks
requested review from
JosueOb,
bytesantiago,
edgardavid2015,
jcalarcon98,
ridouku and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 95.24% 95.42% +0.18%
==========================================
Files 106 107 +1
Lines 2206 2275 +69
Branches 169 173 +4
==========================================
+ Hits 2101 2171 +70
Misses 61 61
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
bytesantiago
approved these changes
Aug 25, 2021
edgardavid2015
approved these changes
Aug 25, 2021
bytesantiago
added a commit
that referenced
this pull request
Aug 30, 2021
* perf: TT-316 removal of ui-list-technologies toggle, technologies-report.guard and their dependants * perf: TT-317 remove unnecessary features from FeatureManagerService * code-smell: TT-316 remove comments and unnecessary variable assignments * code-smell: TT-316 removal of an additional unnecessary import * Tt 319 fix calendar day week view (#738) * fix: TT-319 Fix calendar week and day view * refactor: TT-319 select first day of the month when select on calendar * refactor: TT-319 Change moment library with date Co-authored-by: Andrés Soto <edansrock> * perf: TT-316 Remove technologies-report-guard/ and remove the feature toggle ui-list-technologies (#736) * perf: TT-316 removal of ui-list-technologies toggle, technologies-report.guard and their dependants * code-smell: TT-316 remove comments and unnecessary variable assignments * code-smell: TT-316 removal of an additional unnecessary import * chore(release): 1.50.1 [skip ci]nn * perf: TT-317 remove unnecessary features from FeatureManagerService * fix: TT-325 Fix wront Test in calendar component (#741) * chore(release): 1.50.2 [skip ci]nn * perf: TT-317 remove unnecessary features from FeatureManagerService * code-smell: TT-317 remove code smells indicated by sonarcloud Co-authored-by: EdansRocks <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Jean Carlos Alarcón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When entering to the time entries section → calendar option → and navigating through the months on week and day views, the system automatically changes to the month view again because it renders the component again every time we change to the previous or next month. Also every time we select a month from the month picker it select the actual day (e.g: if today is January 24 and select May it navigates to May 24)
Solution
Now the component keeps the actual day, week or month view, so even if it renders again it keeps the view. Now when we select another month from the month picker it changes to the first day of that month.