Skip to content
Merged
Prev Previous commit
Next Next commit
fix: TT-403 remove method POST
  • Loading branch information
ararcos committed Nov 19, 2021
commit 4bc146ac5d26f98683f8b3cca638f6552be25017
10 changes: 0 additions & 10 deletions V2/serverless.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,6 @@ functions:
route: activities/
authLevel: anonymous

create_time_entry:
handler: time_tracker/time_entries/interface.create_time_entry
events:
- http: true
x-azure-settings:
methods:
- POST
route: time-entries/
authLevel: anonymous

delete_time_entry:
handler: time_tracker/time_entries/interface.delete_time_entry
events:
Expand Down
11 changes: 0 additions & 11 deletions V2/tests/integration/daos/time_entries_dao.test.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,6 @@ def _creator(time_entries):
return _creator


def test_create_time_entry__returns_an_time_entry_dto__when_create_an_time_entry_that_matches_attributes(
create_fake_time_entries, time_entry_factory
):
create_fake_time_entries([])

time_entries_json_dao = TimeEntriesJsonDao(Faker().file_path())
time_entry_data = time_entry_factory()
result = time_entries_json_dao.create(time_entry_data.__dict__)
assert result == TimeEntry(**time_entry_data)


def test_delete__returns_an_time_entry_with_true_deleted__when_an_time_entry_matching_its_id_is_found(
create_fake_time_entries, time_entry_factory
):
Expand Down
15 changes: 0 additions & 15 deletions V2/tests/unit/use_cases/time_entries_use_case_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,6 @@
from time_tracker.time_entries._domain import _use_cases


def test__create_time_entry_function__uses_the_time_entries_service__to_create_time_entry(
mocker: MockFixture, time_entry_factory
):
expected_time_entry = mocker.Mock()
time_entry_service = mocker.Mock(
create=mocker.Mock(return_value=expected_time_entry)
)

time_entry_use_case = _use_cases.CreateTimeEntryUseCase(time_entry_service)
actual_time_entry = time_entry_use_case.create_time_entry(time_entry_factory())

assert time_entry_service.create.called
assert expected_time_entry == actual_time_entry


def test__delete_time_entry_function__uses_the_time_entry_service__to_change_time_entry_deleted(
mocker: MockFixture,
):
Expand Down
1 change: 0 additions & 1 deletion V2/time_tracker/time_entries/_application/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# flake8: noqa
from ._time_entries import create_time_entry
from ._time_entries import delete_time_entry
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# flake8: noqa
from ._create_time_entry import create_time_entry
from ._delete_time_entry import delete_time_entry
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@

from ... import _domain
from ... import _infrastructure
from time_tracker._infrastructure import DB

_JSON_PATH = (
'time_tracker/time_entries/_infrastructure/_data_persistence/time_entries_data.json'
)


def create_time_entry(req: func.HttpRequest) -> func.HttpResponse:
database = DB()
time_entry_dao = _infrastructure.TimeEntriesSQLDao(database)

time_entry_dao = _infrastructure.TimeEntriesJsonDao(_JSON_PATH)
time_entry_service = _domain.TimeEntryService(time_entry_dao)
use_case = _domain._use_cases.CreateTimeEntryUseCase(time_entry_service)

Expand Down
1 change: 0 additions & 1 deletion V2/time_tracker/time_entries/_domain/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@
from ._persistence_contracts import TimeEntriesDao
from ._services import TimeEntryService
from ._use_cases import (
CreateTimeEntryUseCase,
DeleteTimeEntryUseCase
)
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# flake8: noqa
from ._create_time_entry_use_case import CreateTimeEntryUseCase
from ._delete_time_entry_use_case import DeleteTimeEntryUseCase
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ def __init__(self, time_entry_service: TimeEntryService):
self.time_entry_service = time_entry_service

def create_time_entry(self, time_entry_data: TimeEntry) -> TimeEntry:
return self.time_entry_service.create(time_entry_data)
return self.time_entry_service.create(time_entry_data.__dict__)
1 change: 0 additions & 1 deletion V2/time_tracker/time_entries/interface.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# flake8: noqa
from ._application import create_time_entry
from ._application import delete_time_entry