Skip to content
Merged
Prev Previous commit
Next Next commit
fix: TT-403 validation of id as integer
  • Loading branch information
ararcos committed Nov 19, 2021
commit 21ff57cebc56c9d55e544c1fbc5dd20ccc7308f5
4 changes: 2 additions & 2 deletions V2/tests/api/azure/time_entry_azure_endpoints_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def test__time_entry_azure_endpoint__creates_an_time_entry__when_time_entry_has_
assert time_entry_json_data == time_entry_body


def test__time_entry_azure_endpoint__returns_an_time_entry_with_true_deleted__when_an_time_entry_matching_its_id_is_found(
def test__delete_time_entries_azure_endpoint__returns_an_time_entry_with_true_deleted__when_its_id_is_found(
create_temp_time_entries,
):
time_entries_json, tmp_directory = create_temp_time_entries
Expand Down Expand Up @@ -62,4 +62,4 @@ def test__delete_time_entries_azure_endpoint__returns_a_status_code_400__when_ti
response = time_entries.delete_time_entry(req)

assert response.status_code == 400
assert response.get_body() == b'Invalid Format ID'
assert response.get_body() == b'Invalid Format ID'
2 changes: 1 addition & 1 deletion V2/tests/integration/daos/time_entries_dao.test.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_delete__returns_an_time_entry_with_true_deleted__when_an_time_entry_mat
time_entry_dto = time_entries[0]
result = time_entries_json_dao.delete(time_entry_dto.id)

assert result.deleted == True
assert result.deleted is True


def test_delete__returns_none__when_no_time_entry_matching_its_id_is_found(
Expand Down
2 changes: 1 addition & 1 deletion V2/tests/unit/services/time_entry_service_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ def test__delete_time_entry__uses_the_time_entry_dao__to_change_time_entry_delet
deleted_time_entry = time_entry_service.delete(Faker().pyint())

assert time_entry_dao.delete.called
assert expected_time_entry == deleted_time_entry
assert expected_time_entry == deleted_time_entry
2 changes: 1 addition & 1 deletion V2/tests/unit/use_cases/time_entries_use_case_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ def test__delete_time_entry_function__uses_the_time_entry_service__to_change_tim
deleted_time_entry = time_entry_use_case.delete_time_entry(Faker().pyint())

assert time_entry_service.delete.called
assert expected_time_entry == deleted_time_entry
assert expected_time_entry == deleted_time_entry
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,3 @@ def delete_time_entry(req: func.HttpRequest) -> func.HttpResponse:
status_code=400,
mimetype="application/json"
)

Original file line number Diff line number Diff line change
@@ -1,36 +1 @@
[
{
"id": 1,
"start_date": "12/07/2021",
"owner_id": 2,
"description": "Review system of Time Tracker",
"activity_id": 2,
"uri": "http://time_tracker.com",
"technologies": [
"git",
"jira",
"python"
],
"end_date": "12/07/2021",
"deleted": false,
"timezone_offset": "300",
"project_id": 1
},
{
"id": 2,
"start_date": "12/07/2021",
"owner_id": 2,
"description": "Review system of doors in the ioet office Loja, change the current raspberry pi ",
"activity_id": 2,
"uri": null,
"technologies": [
"git",
"jira",
"python"
],
"end_date": "12/07/2021",
"deleted": false,
"timezone_offset": "300",
"project_id": 1
}
]
[{"id": 1, "start_date": "12/07/2021", "owner_id": 2, "description": "Review system of Time Tracker", "activity_id": 2, "uri": "http://time_tracker.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": true, "timezone_offset": "300", "project_id": 1}, {"id": 2, "start_date": "12/07/2021", "owner_id": 2, "description": "Review system of doors in the ioet office Loja, change the current raspberry pi ", "activity_id": 2, "uri": null, "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": false, "timezone_offset": "300", "project_id": 1}]