Skip to content

feat: TT-403 delete v2 time entries #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 22, 2021
Merged

feat: TT-403 delete v2 time entries #346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4676dc4
feat: TT-401 Implemented service, end-point, dao, test- time entries
ararcos Nov 10, 2021
39d2b24
feat: TT-401 validated request create time entry
ararcos Nov 12, 2021
ddf305c
fix: TT-401 implemented faker url
ararcos Nov 12, 2021
5c6d669
feat: TT-403 created end-point to DELETE of time_entries
ararcos Nov 12, 2021
21ff57c
fix: TT-403 validation of id as integer
ararcos Nov 12, 2021
4bc146a
fix: TT-403 remove method POST
ararcos Nov 12, 2021
93d8f16
feat: TT-403 rebase with master
mandres2015 Nov 15, 2021
486c997
feat: TT-403 tests added
mandres2015 Nov 16, 2021
b79d442
refactor: TT-403 correct flake8 lint syntax
mandres2015 Nov 16, 2021
0e1413c
fix: TT-403 comments solved
mandres2015 Nov 19, 2021
878bc24
fix: TT-403 correction of rebase
mandres2015 Nov 19, 2021
08df504
refactor: TT-403 renamed of delete test
ararcos Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: TT-401 validated request create time entry
  • Loading branch information
@ararcos
ararcos committed Nov 19, 2021
commit 39d2b243437ca05a4944d5ee53eefa7e350b8e61
6 changes: 5 additions & 1 deletion V2/tests/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
@pytest.fixture(name='activity_factory')
def _activity_factory() -> activities_domain.Activity:
def _make_activity(
name: str = Faker().name(), description: str = Faker().sentence(), deleted: bool = False, status: int = 1
name: str = Faker().name(),
description: str = Faker().sentence(),
deleted: bool = False,
status: int = 1,
):
activity = activities_domain.Activity(
id=None,
Expand All @@ -20,6 +23,7 @@ def _make_activity(
status=status
)
return activity

return _make_activity


Expand Down
20 changes: 8 additions & 12 deletions V2/tests/integration/daos/time_entries_dao.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,17 @@ def test_create_time_entry__returns_an_time_entry_dto__when_create_an_time_entry

time_entries_json_dao = TimeEntriesJsonDao(Faker().file_path())
time_entry_data = {
"id" : None,
"start_date" : Faker().date(),
"owner_id" : Faker().random_int(),
"id": None,
"start_date": Faker().date(),
"owner_id": Faker().random_int(),
"description": Faker().sentence(),
"activity_id" : Faker().random_int(),
"uri": "http://hola.com",
"technologies" : ["jira","git"],
"activity_id": Faker().random_int(),
"uri": "http://timetracker.com",
"technologies": ["jira", "git"],
"end_date": Faker().date(),
"deleted": Faker().random_int(),
"timezone_offset": "UTC-5",
"deleted": False,
"timezone_offset": "300",
"project_id": Faker().random_int(),
}
result = time_entries_json_dao.create(time_entry_data)
assert result == TimeEntry(**time_entry_data)




1 change: 1 addition & 0 deletions V2/time_tracker/time_entries/_application/_time_entries/_create_time_entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from time_tracker._infrastructure import DB



def create_time_entry(req: func.HttpRequest) -> func.HttpResponse:
database = DB()
time_entry_dao = _infrastructure.TimeEntriesSQLDao(database)
Expand Down
93 changes: 1 addition & 92 deletions V2/time_tracker/time_entries/_infrastructure/_data_persistence/time_entries_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,92 +1 @@
[{
"id": null,
"start_date": "12/07/2021",
"owner_id": 2,
"tenant_id": "asdasdsa",
"description": "No se que poner jajaj ",
"activity_id": 2,
"uri": "http://hola.que.hace.com",
"technologies": ["git", "jira", "python"],
"end_date": "12/07/2021",
"deleted": "asdasdsaadssa",
"timezone_offset": "asdasdsa",
"project_id": 1
}, {
"id": null,
"start_date": "12/07/2021",
"owner_id": 2,
"tenant_id": "asdasdsa",
"description": "No se que poner jajaj ",
"activity_id": 2,
"uri": "http://hola.que.hace.com",
"technologies": ["git", "jira", "python"],
"end_date": "12/07/2021",
"deleted": "asdasdsaadssa",
"timezone_offset": "asdasdsa",
"project_id": 1
}, {
"id": null,
"start_date": "12/07/2021",
"owner_id": 2,
"tenant_id": "asdasdsa",
"description": "No se que poner jajaj ",
"activity_id": 2,
"uri": "http://hola.que.hace.com",
"technologies": ["git", "jira", "python"],
"end_date": "12/07/2021",
"deleted": "asdasdsaadssa",
"timezone_offset": "asdasdsa",
"project_id": 1
}, {
"id": null,
"start_date": "12/07/2021",
"owner_id": 2,
"tenant_id": "asdasdsa",
"description": "No se que poner jajaj ",
"activity_id": 2,
"uri": "http://hola.que.hace.com",
"technologies": ["git", "jira", "python"],
"end_date": "12/07/2021",
"deleted": "asdasdsaadssa",
"timezone_offset": "asdasdsa",
"project_id": 1
}, {
"id": null,
"start_date": "12/07/2021",
"owner_id": 2,
"tenant_id": "asdasdsa",
"description": "No se que poner jajaj ",
"activity_id": 2,
"uri": "http://hola.que.hace.com",
"technologies": ["git", "jira", "python"],
"end_date": "12/07/2021",
"deleted": "asdasdsaadssa",
"timezone_offset": "asdasdsa",
"project_id": 1
}, {
"id": null,
"start_date": "12/07/2021",
"owner_id": 2,
"tenant_id": "asdasdsa",
"description": "No se que poner jajaj ",
"activity_id": 2,
"uri": "http://hola.que.hace.com",
"technologies": ["git", "jira", "python"],
"end_date": "12/07/2021",
"deleted": "asdasdsaadssa",
"timezone_offset": "asdasdsa",
"project_id": 1
}, {
"id": null,
"start_date": "12/07/2021",
"owner_id": 2,
"tenant_id": "asdasdsa",
"description": "No se que poner jajaj ",
"activity_id": 2,
"uri": "http://hola.que.hace.com",
"technologies": ["git", "jira", "python"],
"end_date": "12/07/2021",
"deleted": "asdasdsaadssa",
"timezone_offset": "asdasdsa",
"project_id": 1
}]
[{"id": null, "start_date": "12/07/2021", "owner_id": 2, "tenant_id": "asdasdsa", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "tenant_id": "asdasdsa", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "tenant_id": "asdasdsa", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "tenant_id": "asdasdsa", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "tenant_id": "asdasdsa", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "tenant_id": "asdasdsa", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "tenant_id": "asdasdsa", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": "asdasdsaadssa", "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": 2, "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": false, "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": "2", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": false, "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": "2", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": false, "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": "2", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": false, "timezone_offset": "asdasdsa", "project_id": 1}, {"id": null, "start_date": "12/07/2021", "owner_id": "2", "description": "No se que poner jajaj ", "activity_id": 2, "uri": "http://hola.que.hace.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": false, "timezone_offset": "asdasdsa", "project_id": 1}]