Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TT-201 delete unnecessary parameters in query_builder and i…
…ts tests
  • Loading branch information
kellycastrof committed Apr 5, 2021
commit 8d346679b3484f0b8a6a88df703d4051e7b13551
13 changes: 3 additions & 10 deletions tests/utils/query_builder_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ def test_order_by_condition():
'start_date', Order.DESC
)

assert len(query_builder.get_parameters()) == 2
assert query_builder.orderBy == True
assert len(query_builder.order_by) == 2
assert query_builder.order_by == ('start_date', 'DESC')


def test__build_orderBy():
Expand All @@ -278,13 +278,6 @@ def test__build_orderBy():
)

orderBy_condition = query_builder._CosmosDBQueryBuilder__build_order_By()
expected_order_string = "ORDER BY c.@attribute @order"
expected_order_string = "ORDER BY c.start_date DESC"

assert expected_order_string == orderBy_condition

expected_params = [
{'name': '@attribute', 'value': 'start_date'},
{'name': '@order', 'value': 'DESC'},
]

assert expected_params == query_builder.get_parameters()
2 changes: 0 additions & 2 deletions utils/query_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ def add_sql_offset_condition(self, offset):

def add_sql_order_by_condition(self, attribute: str, order: Order):
self.order_by = (attribute, order.name)
self.parameters.append({'name': '@attribute', 'value': attribute})
self.parameters.append({'name': '@order', 'value': order.name})
return self

def __build_select(self):
Expand Down