Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-201 missed and bad arguments and order by params not supporte…
…d by cosmosdb
  • Loading branch information
kellycastrof committed Apr 4, 2021
commit 8c820edf0b19f77652d658305a8fea295e178b6f
2 changes: 1 addition & 1 deletion time_tracker_api/time_entries/time_entries_dao.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def update(self, id, data: dict, description=None):
event_ctx = self.create_event_context("update", description)

if data.get('update_last_entry_if_overlap'):
self.repository.update_last_entry(data)
self.repository.update_last_entry(data, event_ctx)

time_entry = self.repository.find(id, event_ctx)
self.check_whether_current_user_owns_item(time_entry)
Expand Down
2 changes: 1 addition & 1 deletion time_tracker_api/time_entries/time_entries_repository.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def update_last_entry(self, data: dict, event_context: EventContext):
start_date = str_to_datetime(start_date)

if start_date < end_date:
update_date = {'end_date': start_date}
update_date = {'end_date': data.get('start_date')}
return self.partial_update(
last_entry.id, update_date, event_context
)
Expand Down
9 changes: 5 additions & 4 deletions utils/query_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self):
self.where_conditions = []
self.limit = None
self.offset = None
self.orderBy = False
self.order_by = tuple()

def add_select_conditions(self, columns: List[str] = None):
columns = columns if columns else ["*"]
Expand Down Expand Up @@ -58,7 +58,7 @@ def add_sql_offset_condition(self, offset):
return self

def add_sql_order_by_condition(self, attribute: str, order: Order):
self.orderBy = True
self.order_by = (attribute, order.name)
self.parameters.append({'name': '@attribute', 'value': attribute})
self.parameters.append({'name': '@order', 'value': order.name})
return self
Expand Down Expand Up @@ -89,8 +89,9 @@ def __build_limit(self):
return ""

def __build_order_By(self):
if self.orderBy:
return "ORDER BY c.@attribute @order"
if self.order_by:
attribute, order = self.order_by
return f"ORDER BY c.{attribute} {order}"
else:
return ""

Expand Down