TT-201 validate the current entry and last entry #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kellycastrof merged 12 commits into master from TT-201-validate-the-current-entry-and-last-entry

Apr 12, 2021

Collaborator

VanessaIniguez commented Apr 7, 2021

Allow update last entry with the new flag 'update_last_entry_if_overlap'

kellycastrof and others added 9 commits

April 1, 2021 11:51


          refactor: TT-201 add fucntion to add update last entry flag in model

d2f5d5b


          refactor: TT-201 add update_last_entry and get_last_entry in reposito…

f528a25

…ry, update CosmosDBQueryBuilder with order by condition


          test: TT-201 add test method for get_last_entry

30a8a85


          fix: TT-201 fix import errors and function calls in time_entry_reposi…

4b6beb6

…tory


          fix: TT-201 fix return None in orderBy condition

ad2257a


          fix: TT-201 missed and bad arguments and order by params not supporte…

8c820ed

…d by cosmosdb


          refactor: TT-201 delete unnecessary parameters in query_builder and i…

8d34667

…ts tests

a408915

Merge branch 'TT-201-validate-the-current-entry-and-last-entry' of github.com:ioet/time-tracker-backend into TT-201-validate-the-current-entry-and-last-entry


          refactor: TT-201 Add tests for update last entry and update TimeEntri…

186a5c0

…esDao

VanessaIniguez requested review from kellycastrof, Angeluz-07, eduardisrael, scastillo-jp and thegreatyamori and removed request for kellycastrof

April 7, 2021 21:28

Angeluz-07 reviewed

View reviewed changes

utils/query_builder.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

utils/query_builder.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

tests/utils/query_builder_test.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

tests/utils/query_builder_test.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

tests/utils/query_builder_test.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/api.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_dao.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

eduardisrael reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

eduardisrael reviewed

View reviewed changes

Contributor

eduardisrael left a comment

I left you a suggestion of the get_last_entry method

kellycastrof added 2 commits

April 9, 2021 10:43


          refactor: TT-201 apply changes

7f599d4


          refactor: TT-201 refactor test and return only one instance of TimeEn…

e3b3101

…try in get_lat_entry

kellycastrof requested review from Angeluz-07 and eduardisrael

April 9, 2021 17:07

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_dao.py Outdated Show resolved Hide resolved


          refactor: TT-201 add type hinting and rename start_date_tmp

2a683b1

kellycastrof requested a review from Angeluz-07

April 9, 2021 20:05

Angeluz-07 approved these changes

View reviewed changes

Contributor

Angeluz-07 left a comment

Very good job.

eduardisrael approved these changes

View reviewed changes

kellycastrof merged commit c133c5d into master

kellycastrof deleted the TT-201-validate-the-current-entry-and-last-entry branch

April 12, 2021 20:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

scastillo-jp Awaiting requested review from scastillo-jp

thegreatyamori Awaiting requested review from thegreatyamori

3 more reviewers

kellycastrof kellycastrof left review comments

Angeluz-07 Angeluz-07 approved these changes

eduardisrael eduardisrael approved these changes

Labels

None yet