Skip to content

Create specification for technologies #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 11, 2020
Merged

Create specification for technologies #12

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5185c3f
Fixes #7 create specification for technologies
Angeluz-07 Mar 11, 2020
44092ef
Fixes #7 code review changes in model
Angeluz-07 Mar 11, 2020
a2a4411
Fixes #7 create technology response for server generated fields
Angeluz-07 Mar 11, 2020
3cee248
Fixes #7 add space for linter warning
Angeluz-07 Mar 11, 2020
0f72441
Merge branch 'master' into feature/create-technologies-spec#7
Angeluz-07 Mar 11, 2020
4dbe6fb
Fixes #7 remove no needed post method
Angeluz-07 Mar 11, 2020
f5bbf77
Merge branch 'feature/create-technologies-spec#7' of https://github.c…
Angeluz-07 Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes #7 code review changes in model
  • Loading branch information
@Angeluz-07
Angeluz-07 committed Mar 11, 2020
commit 44092ef05ecd33dfb4a971dd956cb6a3389e6682
6 changes: 3 additions & 3 deletions time_tracker_api/technologies/technologies_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
description='Name of the technology'
),
'created_at': fields.Date(
title='Date',
title='Created',
description='Date of creation'
),
'created_by': fields.String(
required=True,
title='Type',
max_length=30,
title='Creator',
max_length=64,
description='Id of user who first added this technology',
),
Copy link
Contributor

@EliuX EliuX Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let's move these kinds of fields that are generated after creation, i.e. created_at, created_by, tenant_id, etc., to a model called technology_response, this way you will not require them when the technology is being created but this has to be autogenerated.

Copy link
Contributor

@EliuX EliuX Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those would be those ReadOnly fields

})
Expand Down