Create specification for technologies #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliuX
reviewed
Mar 11, 2020
| title='Type', | ||
| max_length=30, | ||
| description='Id of user who first added this technology', | ||
| ), |
Contributor
There was a problem hiding this comment.
Also, let's move these kinds of fields that are generated after creation, i.e. created_at, created_by, tenant_id, etc., to a model called technology_response, this way you will not require them when the technology is being created but this has to be autogenerated.
Contributor
There was a problem hiding this comment.
Those would be those ReadOnly fields
| @ns.route('') | ||
| class Technologies(Resource): | ||
| @ns.doc('list_technologies') | ||
| @ns.marshal_list_with(technology, code=200) |
Contributor
There was a problem hiding this comment.
Then in the @ns.marshal_list_with you will use technology_response.
EliuX
approved these changes
Mar 11, 2020
…om/ioet/time-tracker-api into feature/create-technologies-spec#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.