Conversation
fix: Avoid 500 error creating account when User.person is None
…pm/2023-05-01 chore(deps): update all npm dependencies for playwright
…action/npm/2023-05-01 chore(deps): update all npm dependencies for dev/coverage-action
Avoids losing the listener when DOM is changed dynamically.
* ISE may initiate conflict review Add ISE to list of those roles who can initiate a conflict review. * fix: improve conditional for conflict review action. Add tests. * chore: fix comment typo --------- Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
jennifer-richards
approved these changes
May 4, 2023
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Looks good.
As we discussed last week, github is pointing out that the release branch is ahead of main due to the merge commit from last time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.