Skip to content

fix: Avoid 500 error creating account when User.person is None#5540

Merged
rjsparks merged 3 commits intoietf-tools:mainfrom
jennifer-richards:create-account-no-person
Apr 27, 2023
Merged

fix: Avoid 500 error creating account when User.person is None#5540
rjsparks merged 3 commits intoietf-tools:mainfrom
jennifer-richards:create-account-no-person

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Fixes #5537

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2023

Codecov Report

Merging #5540 (82e5db7) into main (84c1fa1) will decrease coverage by 0.01%.
The diff coverage is 90.17%.

@@            Coverage Diff             @@
##             main    #5540      +/-   ##
==========================================
- Coverage   88.80%   88.80%   -0.01%     
==========================================
  Files         285      285              
  Lines       39611    39756     +145     
==========================================
+ Hits        35177    35304     +127     
- Misses       4434     4452      +18     
Impacted Files Coverage Δ
ietf/__init__.py 0.00% <0.00%> (ø)
ietf/iesg/urls.py 100.00% <ø> (ø)
ietf/meeting/urls.py 86.66% <0.00%> (+5.41%) ⬆️
ietf/nomcom/models.py 91.73% <ø> (ø)
ietf/ietfauth/views.py 91.91% <77.77%> (-0.33%) ⬇️
ietf/iesg/models.py 91.48% <83.33%> (-1.20%) ⬇️
ietf/meeting/views.py 90.99% <88.05%> (-0.16%) ⬇️
ietf/iesg/agenda.py 92.74% <100.00%> (+0.67%) ⬆️
ietf/iesg/resources.py 100.00% <100.00%> (ø)
ietf/iesg/views.py 93.67% <100.00%> (+1.14%) ⬆️
... and 4 more

... and 5 files with indirect coverage changes

Comment thread ietf/ietfauth/views.py Outdated
@rjsparks rjsparks merged commit f835b6f into ietf-tools:main Apr 27, 2023
@jennifer-richards jennifer-richards deleted the create-account-no-person branch April 27, 2023 19:20
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

500 error when creating an account for an email associated with a User that has no related Person

2 participants