fix: allow ISE to initiate conflict review#5570
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom May 3, 2023
Merged
Conversation
Add ISE to list of those roles who can initiate a conflict review.
Contributor
Author
|
For numerous reasons I have NOT tested this code, directly (I haven't yet replicated the environment, and the fork of this code is MASSIVE from a remote location. (So if someone could get this up on a sandbox, I would be happy to test). |
Member
|
See the readme on how to make a local clone that is smaller than the whole thing. |
Member
|
Thanks for this. The PR has one part of the essential fix, but there are a couple of other places that need to be touched and this needs to have tests added to the test suite. I'll work these in. |
Member
|
@elear: I pushed a commit that changes the conditional and adds tests. |
jennifer-richards
approved these changes
May 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #5570 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 285 285
Lines 39756 39757 +1
=======================================
+ Hits 35304 35308 +4
+ Misses 4452 4449 -3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very small change should address #5261 . Very small change to a list.