fix: Don't show reorder UI fixtures unless user can reorder#4785
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4785 +/- ##
==========================================
- Coverage 88.51% 88.50% -0.01%
==========================================
Files 296 296
Lines 39851 39851
==========================================
- Hits 35273 35272 -1
- Misses 4578 4579 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
approved these changes
Nov 23, 2022
| </td> | ||
| <td class="text-end"> | ||
| {% if user|has_role:"Secretariat" or can_manage_materials %} | ||
| {% if pres.document.type.slug != 'bluesheets' or user|has_role:"Secretariat" or meeting.type.slug == 'interim' and can_manage_materials %} |
Collaborator
Author
There was a problem hiding this comment.
So the float-end looks better.
Member
There was a problem hiding this comment.
I don't see, at this point, how the float-end could have been affected?
larseggert
added a commit
to larseggert/datatracker
that referenced
this pull request
Nov 29, 2022
…ls#4785) Fixes ietf-tools#4773 Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
rjsparks
added a commit
that referenced
this pull request
Dec 2, 2022
* Handle single-word author names * Some i18n names, e.g., "शिला के.सी." have a dot at the end that is also part of the ASCII, e.g., "Shilaa Kesii." That trailing dot breaks extract_authors(). Avoid this issue by stripping the dot from the ASCII. * Honorifics need to be part of the extracted ASCII name (e.g., "Lady Garcia") * feat: stop supporting pre-tzaware migration database dumps. (#4782) * feat: stop supporting pre-tzaware migration database dumps. * chore: remove unnecessary env variable * chore: Use `codespell` to fix typos in comments. (#4794) First part of replacement of #4651 * feat: Only show IPR search form when not showing search results (#4793) * feat: Only show IPR search form when not showing search results Put it into a collapsible that is only expanded by default when not showing search results. Fixes #4569 * Don't use example target name * fix: Don't show reorder UI fixtures unless user can reorder (#4785) Fixes #4773 Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * chore: Update deps and fix resulting HTML validation issues (#4790) * ci: add missing build matrix config for test-playwright-legacy step * Single-letter last names exist (e.g., "Carolina de la O") * Align regex with others * Fix extraction of very long author names * Need to be more general * Add comment * Also handle i18n names with trailing semicolons * Name suffixes need to be part of the extracted author names * Handle i18n names with embedded commas Co-authored-by: Robert Sparks <rjsparks@nostrum.com> Co-authored-by: Nicolas Giard <github@ngpixel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4773