feat: stop supporting pre-tzaware migration database dumps.#4782
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4782 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 296 296
Lines 39851 39851
=======================================
+ Hits 35273 35276 +3
+ Misses 4578 4575 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NGPixel
approved these changes
Nov 22, 2022
jennifer-richards
approved these changes
Nov 24, 2022
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
One minor suggestion in a script - take it or leave it and merge away!
| fi | ||
| fi | ||
| echo "Running Datatracker migrations..." | ||
| /usr/local/bin/python $WORKSPACEDIR/ietf/manage.py migrate --settings=settings_local |
Member
There was a problem hiding this comment.
This is the only spot using WORKSPACEDIR in this script - everywhere else is just an explicit ./. Get rid of the variable (or replace ./ everywhere)?
larseggert
pushed a commit
to larseggert/datatracker
that referenced
this pull request
Nov 29, 2022
…ls#4782) * feat: stop supporting pre-tzaware migration database dumps. * chore: remove unnecessary env variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.