chore: Fix spelling/wording via codespell#4651
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4651 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.01%
==========================================
Files 296 296
Lines 39730 39730
==========================================
- Hits 35126 35125 -1
- Misses 4604 4605 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| ), | ||
| migrations.CreateModel( | ||
| name='Whitelisted', | ||
| name='Allowlisted', |
There was a problem hiding this comment.
Making this change in the 0001_initial migration will have no effect on the production database. This file should be left alone to allow the migration system to work properly.
What needs to happen instead is a change to the model (and it's associated admin and resource files) and create a new migration that will make the change to the data.
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
This really should be split into two PRs.
It is not a chore just fixing spelling as advertised - it is a change to the models and the api.
Please create one PR that changes the mailinglists models (and the related changes that requires, including the new migration it needs). This one should be labeled a feat: (Even though it's a breaking change for anyone depending on the v1 api, we've already decided we won't treat that as something that bumps our major version number).
Please use a separate PR for the changes that do not affect the database and api. This one can be a chore.
Consider breaking the changes that affect settings, code and text shown to users apart from changes that only affect comments if that's not too hard to do. It would make looking for anything outside the repository that needs to be changed to follow along simpler.
First part of replacement of ietf-tools#4651
Second part of replacement of ietf-tools#4651 @rjsparks, I probably need to revert some things here, and I also still need to add that new migration - how do I do that?
First part of replacement of #4651
First part of replacement of ietf-tools#4651
* Handle single-word author names * Some i18n names, e.g., "शिला के.सी." have a dot at the end that is also part of the ASCII, e.g., "Shilaa Kesii." That trailing dot breaks extract_authors(). Avoid this issue by stripping the dot from the ASCII. * Honorifics need to be part of the extracted ASCII name (e.g., "Lady Garcia") * feat: stop supporting pre-tzaware migration database dumps. (#4782) * feat: stop supporting pre-tzaware migration database dumps. * chore: remove unnecessary env variable * chore: Use `codespell` to fix typos in comments. (#4794) First part of replacement of #4651 * feat: Only show IPR search form when not showing search results (#4793) * feat: Only show IPR search form when not showing search results Put it into a collapsible that is only expanded by default when not showing search results. Fixes #4569 * Don't use example target name * fix: Don't show reorder UI fixtures unless user can reorder (#4785) Fixes #4773 Co-authored-by: Robert Sparks <rjsparks@nostrum.com> * chore: Update deps and fix resulting HTML validation issues (#4790) * ci: add missing build matrix config for test-playwright-legacy step * Single-letter last names exist (e.g., "Carolina de la O") * Align regex with others * Fix extraction of very long author names * Need to be more general * Add comment * Also handle i18n names with trailing semicolons * Name suffixes need to be part of the extracted author names * Handle i18n names with embedded commas Co-authored-by: Robert Sparks <rjsparks@nostrum.com> Co-authored-by: Nicolas Giard <github@ngpixel.com>
2 participants
No description provided.