Skip to content

fix: improve RH panel behavior at small viewport sizes - #3801

Merged
jennifer-richards merged 4 commits into
ietf-tools:feat/bs5from
painless-security:jennifer/nav-styling
Apr 8, 2022
Merged

fix: improve RH panel behavior at small viewport sizes#3801
jennifer-richards merged 4 commits into
ietf-tools:feat/bs5from
painless-security:jennifer/nav-styling

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

Also cleans up a merge error that led to incorrect vertical alignment of the RH navigation items.

Fixes #3798

  * drop card styling
  * use `btn-group-sm` for compact timezone picker
  * limit overall height of #righthand-panel
  * remove redundant CSS merge artifact
@codecov

codecov Bot commented Apr 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3801 (fdbb99e) into feat/bs5 (8bd4851) will increase coverage by 0.01%.
The diff coverage is 98.21%.

❗ Current head fdbb99e differs from pull request most recent head e5396a8. Consider uploading reports for the commit e5396a8 to get more accurate results

@@             Coverage Diff              @@
##           feat/bs5    #3801      +/-   ##
============================================
+ Coverage     87.97%   87.98%   +0.01%     
============================================
  Files           296      297       +1     
  Lines         38795    38804       +9     
============================================
+ Hits          34130    34142      +12     
+ Misses         4665     4662       -3     
Impacted Files Coverage Δ
ietf/meeting/models.py 86.08% <ø> (ø)
ietf/meeting/utils.py 90.27% <ø> (-0.29%) ⬇️
ietf/meeting/views.py 90.73% <95.00%> (+0.02%) ⬆️
ietf/doc/templatetags/ballot_icon.py 84.89% <100.00%> (ø)
ietf/doc/templatetags/ietf_filters.py 81.25% <100.00%> (ø)
ietf/doc/views_ballot.py 91.60% <100.00%> (ø)
ietf/doc/views_charter.py 88.72% <100.00%> (ø)
ietf/doc/views_status_change.py 93.04% <100.00%> (ø)
ietf/ietfauth/views.py 90.57% <100.00%> (ø)
ietf/liaisons/widgets.py 86.11% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3619d3b...e5396a8. Read the comment docs.

@jennifer-richards
jennifer-richards merged commit 2247a36 into ietf-tools:feat/bs5 Apr 8, 2022
@jennifer-richards
jennifer-richards deleted the jennifer/nav-styling branch April 8, 2022 17:52
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants