Skip to content

fix: improve RH panel behavior at small viewport sizes #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-richards merged 4 commits into from
Apr 8, 2022
Merged

fix: improve RH panel behavior at small viewport sizes #3801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab2bcad
fix: align nav links to top of RH panel
jennifer-richards Apr 8, 2022
6c4cd37
fix: allow timezone picker to wrap
jennifer-richards Apr 8, 2022
fdbb99e
fix: improve RH panel behavior at small viewport sizes
jennifer-richards Apr 8, 2022
e5396a8
fix: remove leftover invalid CSS class
jennifer-richards Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ietf/static/css/ietf.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,10 @@ table tbody.meta {
}

// Style the righthand navigation panel
#righthand-panel {
max-height: 80vh;
}

#righthand-nav {
height: 70vh;
width: inherit;
Expand Down Expand Up @@ -993,8 +997,3 @@ td.position-empty {
#current-time {
display: inline-block;
}

// righthand nav panel styling
#righthand-nav {
width: inherit;
}
6 changes: 3 additions & 3 deletions ietf/static/js/ietf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ $(function () {
.attr("tabindex", 0)
.after($(`
<div class="col-xl-2 ps-0 small">
<div id="righthand-card" class="position-fixed card d-flex flex-column justify-content-start align-items-start">
<nav id="righthand-nav" class="card-body navbar navbar-light bg-light overflow-auto"></nav>
<div id="righthand-panel" class="position-fixed d-flex flex-column justify-content-between align-items-start">
<nav id="righthand-nav" class="navbar navbar-light bg-light overflow-auto align-items-start flex-fill"></nav>
</div></div>
</div>
`));
Expand Down Expand Up @@ -236,7 +236,7 @@ $(function () {
});

if (haveExtraNav) {
$('#righthand-card').append('<div id="righthand-extra" class="card-body"></div>');
$('#righthand-panel').append('<div id="righthand-extra" class="py-3"></div>');
extraNav.children().appendTo('#righthand-extra');
extraNav.remove();
}
Expand Down
2 changes: 1 addition & 1 deletion ietf/templates/meeting/agenda.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<div class="px-3">
Showing <span class="current-tz">{{ timezone }}</span> time
</div>
<div class="px-3 w-100">
<div class="align-self-center">
{% include 'meeting/tz-display.html' with id_suffix="-rh" meeting_timezone=timezone minimal=True only %}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ietf/templates/meeting/tz-display.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{% load origin %}
{% origin %}
{% firstof id_suffix "" as suffix %}
<div class="tz-display {% if minimal %}btn-group{% else %}input-group{% endif %} my-3">
<div class="tz-display {% if minimal %}btn-group btn-group-sm my-2{% else %}input-group my-3{% endif %} flex-wrap">
{% if not minimal %}<label class="input-group-text border-primary bg-white fw-bold">Time zone:</label>{% endif %}
{% if meeting_timezone is not None %}
<input type="radio"
Expand Down