Skip to content

Fix socket.infoHashes access error #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feross merged 3 commits into from
Feb 28, 2017
Merged

Fix socket.infoHashes access error #208

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2c2b8f
do not access socket.infoHashes if socket is destroyed
feross Feb 21, 2017
fe11c69
do not close socket even when it's not in other swarms
feross Feb 21, 2017
ccb50a7
add one missing self.destroyed check
feross Feb 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add one missing self.destroyed check
  • Loading branch information
@feross
feross committed Feb 21, 2017
commit ccb50a7ee976dcce481d07bb129a489380d4c247
1 change: 1 addition & 0 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,7 @@ Server.prototype._onWebSocketRequest = function (socket, opts, params) {
debug('got answer %s from %s', JSON.stringify(params.answer), params.peer_id)

self.getSwarm(params.info_hash, function (err, swarm) {
if (self.destroyed) return
if (err) return self.emit('warning', err)
if (!swarm) {
return self.emit('warning', new Error('no swarm with that `info_hash`'))
Expand Down