Skip to content

add 'user-agent' in HTTP header #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feross merged 5 commits into from
Jan 16, 2017
Merged

add 'user-agent' in HTTP header #179

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
725527a
add 'user-agent' in HTTP header
zunsthy Oct 28, 2016
0444e93
fix eslint
zunsthy Oct 28, 2016
7ae7a2c
Revert "fix eslint"
zunsthy Nov 6, 2016
e0ede27
Revert "add 'user-agent' in HTTP header"
zunsthy Nov 6, 2016
bd8bc9f
add 'user-agent' in HTTP header
zunsthy Nov 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/client/http-tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,14 @@ HTTPTracker.prototype._request = function (requestUrl, params, cb) {
var self = this
var u = requestUrl + (requestUrl.indexOf('?') === -1 ? '?' : '&') +
common.querystringStringify(params)
var opts = {
url: u,
header: {
Copy link
Member

@feross feross Jan 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this should be headers.

Copy link
Contributor Author

@zunsthy zunsthy Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I ignored it. Thank you for correction : )

'user-agent': self.client._userAgent || ''
Copy link
Member

@feross feross Jan 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where self.client._userAgent actually gets set. Did you forget to commit changes to client.js?

}
}

get.concat(u, function (err, res, data) {
get.concat(opts, function (err, res, data) {
if (self.destroyed) return
if (err) return self.client.emit('warning', err)
if (res.statusCode !== 200) {
Expand Down