add 'user-agent' in HTTP header #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
reviewed
Jan 16, 2017
Member
feross
left a comment
feross
left a comment
There was a problem hiding this comment.
This PR is also missing a test.
| var opts = { | ||
| url: u, | ||
| header: { | ||
| 'user-agent': self.client._userAgent || '' |
Member
There was a problem hiding this comment.
I don't see where self.client._userAgent actually gets set. Did you forget to commit changes to client.js?
feross
approved these changes
Jan 16, 2017
Member
feross
left a comment
feross
left a comment
There was a problem hiding this comment.
I'll merge and fix the remaining issues in a followup commit.
feross
reviewed
Jan 16, 2017
| common.querystringStringify(params) | ||
| var opts = { | ||
| url: u, | ||
| header: { |
Contributor
Author
There was a problem hiding this comment.
Sorry, I ignored it. Thank you for correction : )
feross
added a commit
that referenced
this pull request
Jan 16, 2017
Member
|
8.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webtorrent/webtorrent#962